Re: [PATCH 2/2] platform/chrome: typec: Register Type C switches

2020-05-18 Thread Prashant Malani
Hi Enric, On Thu, Apr 30, 2020 at 12:25:10AM +0200, Enric Balletbo i Serra wrote: > Hi Prashant, > > Following my previous comments ... > > On 23/4/20 0:22, Prashant Malani wrote: > > Register Type C mux and switch handles, when provided via firmware > > bindings. These will allow the cros-ec-ty

Re: [PATCH 2/2] platform/chrome: typec: Register Type C switches

2020-04-29 Thread Enric Balletbo i Serra
Hi Prashant, On 30/4/20 1:02, Prashant Malani wrote: > Hi Enric, > > Thanks for your review. Kindly see inline: > > On Wed, Apr 29, 2020 at 3:22 PM Enric Balletbo i Serra > wrote: >> >> Hi Prashant, >> >> Thank you for your patch. >> >> On 23/4/20 0:22, Prashant Malani wrote: >>> Register Type

Re: [PATCH 2/2] platform/chrome: typec: Register Type C switches

2020-04-29 Thread Prashant Malani
Hi Enric, Thanks for your review. Kindly see inline: On Wed, Apr 29, 2020 at 3:22 PM Enric Balletbo i Serra wrote: > > Hi Prashant, > > Thank you for your patch. > > On 23/4/20 0:22, Prashant Malani wrote: > > Register Type C mux and switch handles, when provided via firmware > > bindings. These

Re: [PATCH 2/2] platform/chrome: typec: Register Type C switches

2020-04-29 Thread Enric Balletbo i Serra
Hi Prashant, Following my previous comments ... On 23/4/20 0:22, Prashant Malani wrote: > Register Type C mux and switch handles, when provided via firmware > bindings. These will allow the cros-ec-typec driver, and also alternate > mode drivers to configure connected Muxes correctly, according t

Re: [PATCH 2/2] platform/chrome: typec: Register Type C switches

2020-04-29 Thread Enric Balletbo i Serra
Hi Prashant, Thank you for your patch. On 23/4/20 0:22, Prashant Malani wrote: > Register Type C mux and switch handles, when provided via firmware > bindings. These will allow the cros-ec-typec driver, and also alternate > mode drivers to configure connected Muxes correctly, according to PD > in