Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-22 Thread atull
On Fri, 22 Aug 2014, Mark Brown wrote: > On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: > > > +config SENSORS_LTC2978_REGULATOR > > + boolean "Regulator support for LTC2974, LTC2978, LTC3880, and LTC3883" > > + default n > > No need to say default n here, it's

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-22 Thread atull
On Fri, 22 Aug 2014, Mark Brown wrote: On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: +config SENSORS_LTC2978_REGULATOR + boolean Regulator support for LTC2974, LTC2978, LTC3880, and LTC3883 + default n No need to say default n here, it's the default

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread Guenter Roeck
On Thu, Aug 21, 2014 at 08:26:22PM -0500, Mark Brown wrote: > On Thu, Aug 21, 2014 at 06:18:10PM -0700, Guenter Roeck wrote: > > On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote: > > > On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com > > > wrote: > > > > This all

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread Mark Brown
On Thu, Aug 21, 2014 at 06:18:10PM -0700, Guenter Roeck wrote: > On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote: > > On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: > > This all looks very much like pmbus could use regmap and then the regmap > > helpers.

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread Guenter Roeck
On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote: > On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: > > > +config SENSORS_LTC2978_REGULATOR > > + boolean "Regulator support for LTC2974, LTC2978, LTC3880, and LTC3883" > > + default n > > No need to say

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread Mark Brown
On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: > +config SENSORS_LTC2978_REGULATOR > + boolean "Regulator support for LTC2974, LTC2978, LTC3880, and LTC3883" > + default n No need to say default n here, it's the default default. > + depends on

[PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread atull
From: Alan Tull Add support for enabling or disabling all supplies. Signed-off-by: Alan Tull --- drivers/hwmon/pmbus/Kconfig |9 ++ drivers/hwmon/pmbus/ltc2978.c | 69 + 2 files changed, 78 insertions(+) diff --git

[PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread atull
From: Alan Tull at...@opensource.altera.com Add support for enabling or disabling all supplies. Signed-off-by: Alan Tull at...@opensource.altera.com --- drivers/hwmon/pmbus/Kconfig |9 ++ drivers/hwmon/pmbus/ltc2978.c | 69 + 2 files changed,

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread Mark Brown
On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: +config SENSORS_LTC2978_REGULATOR + boolean Regulator support for LTC2974, LTC2978, LTC3880, and LTC3883 + default n No need to say default n here, it's the default default. + depends on SENSORS_LTC2978

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread Guenter Roeck
On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote: On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: +config SENSORS_LTC2978_REGULATOR + boolean Regulator support for LTC2974, LTC2978, LTC3880, and LTC3883 + default n No need to say default n

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread Mark Brown
On Thu, Aug 21, 2014 at 06:18:10PM -0700, Guenter Roeck wrote: On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote: On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: This all looks very much like pmbus could use regmap and then the regmap helpers. I'd not

Re: [PATCH 2/2] pmbus: ltc2978: add regulator gating

2014-08-21 Thread Guenter Roeck
On Thu, Aug 21, 2014 at 08:26:22PM -0500, Mark Brown wrote: On Thu, Aug 21, 2014 at 06:18:10PM -0700, Guenter Roeck wrote: On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote: On Thu, Aug 21, 2014 at 05:21:26PM -0500, at...@opensource.altera.com wrote: This all looks very