Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-26 Thread Yingjoe Chen
On Tue, 2015-05-26 at 08:05 +0200, Sascha Hauer wrote: > On Thu, May 21, 2015 at 04:22:31PM +0800, YH Huang wrote: > > On Mon, 2015-05-18 at 11:42 +0800, Daniel Kurtz wrote: <...> > > > On Mon, May 11, 2015 at 5:26 PM, YH Huang wrote: > > > > + > > > > +static const struct of_device_id mtk_disp_pw

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-25 Thread Sascha Hauer
On Thu, May 21, 2015 at 04:22:31PM +0800, YH Huang wrote: > On Mon, 2015-05-18 at 11:42 +0800, Daniel Kurtz wrote: > > On Mon, May 11, 2015 at 5:26 PM, YH Huang wrote: > > > Add display PWM driver support to modify backlight for MT8173/MT6595. > > > > > > Signed-off-by: YH Huang > > > --- > > >

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-21 Thread YH Huang
On Mon, 2015-05-18 at 11:42 +0800, Daniel Kurtz wrote: > On Mon, May 11, 2015 at 5:26 PM, YH Huang wrote: > > Add display PWM driver support to modify backlight for MT8173/MT6595. > > > > Signed-off-by: YH Huang > > --- > > drivers/pwm/Kconfig | 9 ++ > > drivers/pwm/Makefile

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-17 Thread Daniel Kurtz
On Mon, May 11, 2015 at 5:26 PM, YH Huang wrote: > Add display PWM driver support to modify backlight for MT8173/MT6595. > > Signed-off-by: YH Huang > --- > drivers/pwm/Kconfig | 9 ++ > drivers/pwm/Makefile| 1 + > drivers/pwm/pwm-disp-mediatek.c | 225 > +++

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 16:34 +0200, Matthias Brugger wrote: > 2015-05-12 15:32 GMT+02:00 Thierry Reding : > > On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: > >> Add display PWM driver support to modify backlight for MT8173/MT6595. > >> > >> Signed-off-by: YH Huang > >> --- > >> drivers

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 15:32 +0200, Thierry Reding wrote: > On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: > > Add display PWM driver support to modify backlight for MT8173/MT6595. > > > > Signed-off-by: YH Huang > > --- > > drivers/pwm/Kconfig | 9 ++ > > drivers/pwm/Mak

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 15:00 +0200, Sascha Hauer wrote: > On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: > > + > > +static int mtk_disp_pwm_probe(struct platform_device *pdev) > > +{ > > + struct mtk_disp_pwm_chip *pwm; > > The struct mtk_disp_pwm_chip * is named 'mpc' in the other fun

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 14:44 +0200, Matthias Brugger wrote: > 2015-05-12 14:37 GMT+02:00 Matthias Brugger : > > Hi YH, > > > > 2015-05-11 11:26 GMT+02:00 YH Huang : > >> Add display PWM driver support to modify backlight for MT8173/MT6595. > >> > >> Signed-off-by: YH Huang > >> --- > >> drivers/pw

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-14 Thread YH Huang
On Tue, 2015-05-12 at 14:37 +0200, Matthias Brugger wrote: > Hi YH, > > 2015-05-11 11:26 GMT+02:00 YH Huang : > > Add display PWM driver support to modify backlight for MT8173/MT6595. > > > > Signed-off-by: YH Huang > > --- > > drivers/pwm/Kconfig | 9 ++ > > drivers/pwm/Makefile

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-12 Thread Matthias Brugger
2015-05-12 15:32 GMT+02:00 Thierry Reding : > On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: >> Add display PWM driver support to modify backlight for MT8173/MT6595. >> >> Signed-off-by: YH Huang >> --- >> drivers/pwm/Kconfig | 9 ++ >> drivers/pwm/Makefile|

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-12 Thread Thierry Reding
On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: > Add display PWM driver support to modify backlight for MT8173/MT6595. > > Signed-off-by: YH Huang > --- > drivers/pwm/Kconfig | 9 ++ > drivers/pwm/Makefile| 1 + > drivers/pwm/pwm-disp-mediatek.c | 225 > ++

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-12 Thread Sascha Hauer
On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: > + > +static int mtk_disp_pwm_probe(struct platform_device *pdev) > +{ > + struct mtk_disp_pwm_chip *pwm; The struct mtk_disp_pwm_chip * is named 'mpc' in the other functions. For consistency reasons you should do that here aswell. >

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-12 Thread Matthias Brugger
2015-05-12 14:37 GMT+02:00 Matthias Brugger : > Hi YH, > > 2015-05-11 11:26 GMT+02:00 YH Huang : >> Add display PWM driver support to modify backlight for MT8173/MT6595. >> >> Signed-off-by: YH Huang >> --- >> drivers/pwm/Kconfig | 9 ++ >> drivers/pwm/Makefile| 1 + >>

Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-12 Thread Matthias Brugger
Hi YH, 2015-05-11 11:26 GMT+02:00 YH Huang : > Add display PWM driver support to modify backlight for MT8173/MT6595. > > Signed-off-by: YH Huang > --- > drivers/pwm/Kconfig | 9 ++ > drivers/pwm/Makefile| 1 + > drivers/pwm/pwm-disp-mediatek.c | 225 > +++

[PATCH 2/2] pwm: add Mediatek display PWM driver support

2015-05-11 Thread YH Huang
Add display PWM driver support to modify backlight for MT8173/MT6595. Signed-off-by: YH Huang --- drivers/pwm/Kconfig | 9 ++ drivers/pwm/Makefile| 1 + drivers/pwm/pwm-disp-mediatek.c | 225 3 files changed, 235 insertions(+)