Re: [PATCH 2/2] rcu/tree: Clarify comments about FQS loop reporting quiescent states

2020-07-30 Thread Paul E. McKenney
On Thu, Jul 30, 2020 at 09:21:52PM -0400, Joel Fernandes wrote: > On Thu, Jul 30, 2020 at 09:35:20AM -0700, Paul E. McKenney wrote: > > On Wed, Jul 29, 2020 at 11:25:19PM -0400, Joel Fernandes wrote: > > > On Wed, Jul 29, 2020 at 11:02 PM Joel Fernandes (Google) > > > wrote: > > > > > > > > At lea

Re: [PATCH 2/2] rcu/tree: Clarify comments about FQS loop reporting quiescent states

2020-07-30 Thread Joel Fernandes
On Thu, Jul 30, 2020 at 09:35:20AM -0700, Paul E. McKenney wrote: > On Wed, Jul 29, 2020 at 11:25:19PM -0400, Joel Fernandes wrote: > > On Wed, Jul 29, 2020 at 11:02 PM Joel Fernandes (Google) > > wrote: > > > > > > At least since v4.19, the FQS loop no longer reports quiescent states > > > > I m

Re: [PATCH 2/2] rcu/tree: Clarify comments about FQS loop reporting quiescent states

2020-07-30 Thread Paul E. McKenney
On Wed, Jul 29, 2020 at 11:25:19PM -0400, Joel Fernandes wrote: > On Wed, Jul 29, 2020 at 11:02 PM Joel Fernandes (Google) > wrote: > > > > At least since v4.19, the FQS loop no longer reports quiescent states > > I meant here, "FQS loop no longer reports quiescent states for offline CPUs." > >

Re: [PATCH 2/2] rcu/tree: Clarify comments about FQS loop reporting quiescent states

2020-07-29 Thread Joel Fernandes
On Wed, Jul 29, 2020 at 11:02 PM Joel Fernandes (Google) wrote: > > At least since v4.19, the FQS loop no longer reports quiescent states I meant here, "FQS loop no longer reports quiescent states for offline CPUs." Sorry, - Joel > unless it is a dire situation where an offlined CPU failed t

[PATCH 2/2] rcu/tree: Clarify comments about FQS loop reporting quiescent states

2020-07-29 Thread Joel Fernandes (Google)
At least since v4.19, the FQS loop no longer reports quiescent states unless it is a dire situation where an offlined CPU failed to report a quiescent state. Let us clarify the comment in rcu_gp_init() inorder to keep the comment current. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/tre