Ram wrote:
>
> On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
> >
> > out:
> > - return newsize;
> > + return ra->prev_page + 1;
>
> This change introduces one key behavioural change in
> page_cache_readahead(). Instead of returning the number-of-pages
> successfully read, it now returns the
Ram wrote:
On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
out:
- return newsize;
+ return ra-prev_page + 1;
This change introduces one key behavioural change in
page_cache_readahead(). Instead of returning the number-of-pages
successfully read, it now returns the next-page-index
On Wed, 2005-03-09 at 16:03, Steven Pratt wrote:
> Ram wrote:
>
> >On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
> >
> >
> >..snip...
> >
> >
> >
> >>@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac
> >>}
> >>
> >> out:
> >>- return newsize;
> >>+ return ra->prev_page +
Ram wrote:
On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
..snip...
@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac
}
out:
- return newsize;
+ return ra->prev_page + 1;
This change introduces one key behavioural change in
page_cache_readahead(). Instead of returning
On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
..snip...
> @@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac
> }
>
> out:
> - return newsize;
> + return ra->prev_page + 1;
This change introduces one key behavioural change in
page_cache_readahead(). Instead of
On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
..snip...
@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac
}
out:
- return newsize;
+ return ra-prev_page + 1;
This change introduces one key behavioural change in
page_cache_readahead(). Instead of returning
Ram wrote:
On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
..snip...
@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac
}
out:
- return newsize;
+ return ra-prev_page + 1;
This change introduces one key behavioural change in
page_cache_readahead(). Instead of returning
On Wed, 2005-03-09 at 16:03, Steven Pratt wrote:
Ram wrote:
On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
..snip...
@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac
}
out:
- return newsize;
+ return ra-prev_page + 1;
This change
Oleg Nesterov <[EMAIL PROTECTED]> wrote:
>
> ~$ time dd conv=notrunc if=/tmp/GIG of=/tmp/dummy bs=$((4096+512))
>
> 2.6.11-clean:real=370.35 user=0.16 sys=14.66
> 2.6.11-patched: real=234.49 user=0.19 sys=12.41
whoa, nice. Ram, can you put this through the torture-test sometime?
1. Current code can't always detect sequential reading, in case
when read size is not PAGE_CACHE_SIZE aligned.
If application reads the file by 4096+512 chunks, we have:
1st read: first read detected, prev_page = 2.
2nd read: offset == 2, the read is considered random.
1. Current code can't always detect sequential reading, in case
when read size is not PAGE_CACHE_SIZE aligned.
If application reads the file by 4096+512 chunks, we have:
1st read: first read detected, prev_page = 2.
2nd read: offset == 2, the read is considered random.
Oleg Nesterov [EMAIL PROTECTED] wrote:
~$ time dd conv=notrunc if=/tmp/GIG of=/tmp/dummy bs=$((4096+512))
2.6.11-clean:real=370.35 user=0.16 sys=14.66
2.6.11-patched: real=234.49 user=0.19 sys=12.41
whoa, nice. Ram, can you put this through the torture-test sometime?
12 matches
Mail list logo