Re: [PATCH 2/2] regulator: Add driver for cros-ec-regulator

2020-06-10 Thread Mark Brown
On Wed, Jun 10, 2020 at 12:31:53PM +0800, Pi-Hsun Shih wrote: > On Tue, Jun 9, 2020 at 7:19 PM Mark Brown wrote: > > On Tue, Jun 09, 2020 at 03:59:55PM +0800, Pi-Hsun Shih wrote: > > > + int min_mV = DIV_ROUND_UP(min_uV, 1000); > > > + int max_mV = max_uV / 1000; > > > + struct

Re: [PATCH 2/2] regulator: Add driver for cros-ec-regulator

2020-06-09 Thread Pi-Hsun Shih
Thanks for the review, some inline reply: On Tue, Jun 9, 2020 at 7:19 PM Mark Brown wrote: > > On Tue, Jun 09, 2020 at 03:59:55PM +0800, Pi-Hsun Shih wrote: > > > +static int cros_ec_regulator_set_state(struct regulator_dev *dev, bool > > enable) > > +{ > > + struct cros_ec_regulator_data

Re: [PATCH 2/2] regulator: Add driver for cros-ec-regulator

2020-06-09 Thread Mark Brown
On Tue, Jun 09, 2020 at 03:59:55PM +0800, Pi-Hsun Shih wrote: > +static int cros_ec_regulator_set_state(struct regulator_dev *dev, bool > enable) > +{ > + struct cros_ec_regulator_data *data = rdev_get_drvdata(dev); > + struct ec_params_regulator_enable cmd = { > + .index =

[PATCH 2/2] regulator: Add driver for cros-ec-regulator

2020-06-09 Thread Pi-Hsun Shih
Add driver for cros-ec-regulator, representing a voltage regulator that is connected and controlled by ChromeOS EC, and is controlled by kernel with EC host commands. Signed-off-by: Pi-Hsun Shih --- This patch contains function cros_ec_cmd that is copied from the series: