Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Mark Brown
On Tue, Sep 10, 2013 at 11:45:41AM -0600, Stephen Warren wrote: > Sounds reasonable. It's a little long but regulator-enable-ramp-delay > might be better since all the common regulator properties to date are > named regulator-xxx. Yes, I just didn't bother typing the whole thing out. signature.

Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Stephen Warren
On 09/10/2013 10:51 AM, Mark Brown wrote: > On Tue, Sep 10, 2013 at 09:11:13AM -0600, Stephen Warren wrote: > >>> +- regulator-enable-time: Turn ON time for regulator(in uS) > >> Bike-shedding slightly: This isn't really the time it takes to >> enable a regulator, but the time the voltage takes t

Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Stephen Warren
On 09/10/2013 11:38 AM, Mark Brown wrote: > On Tue, Sep 10, 2013 at 11:34:13AM -0600, Stephen Warren wrote: > >> I notice there's a regulator-ramp-delay property, already documented >> right above this new property. Is this a conflicting usage of the same >> term, or should that existing property

Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Mark Brown
On Tue, Sep 10, 2013 at 11:34:13AM -0600, Stephen Warren wrote: > I notice there's a regulator-ramp-delay property, already documented > right above this new property. Is this a conflicting usage of the same > term, or should that existing property just be used in this case too? That's for a ramp

Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Mark Brown
On Tue, Sep 10, 2013 at 09:11:13AM -0600, Stephen Warren wrote: > > +- regulator-enable-time: Turn ON time for regulator(in uS) > Bike-shedding slightly: This isn't really the time it takes to enable a > regulator, but the time the voltage takes to become stable, or settle. > Perhaps name the pro

Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Mark Brown
On Tue, Sep 10, 2013 at 06:44:40PM +0530, Laxman Dewangan wrote: > Here my intention for turn-on time is the time from OFF state to ON > state and the ON voltage settled on this time. > This time is separate from underlying enable time of the device i.e. > will not get added. > We observe in some

Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Stephen Warren
On 09/10/2013 05:18 AM, Laxman Dewangan wrote: > The Turn-ON time of the regulator depends on the regulator device's > electrical characteristics. Sometimes regulator turn-on time also > depends on the capacitive load on the given platform and it can be > more than the datasheet value. > > The dri

Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Laxman Dewangan
On Tuesday 10 September 2013 05:39 PM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Sep 10, 2013 at 04:48:08PM +0530, Laxman Dewangan wrote: +- regulator-enable-time: Turn ON time for regulator(in uS) This is unclear - what is a "turn on time" and is this in addition to or separat

Re: [PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Mark Brown
On Tue, Sep 10, 2013 at 04:48:08PM +0530, Laxman Dewangan wrote: > +- regulator-enable-time: Turn ON time for regulator(in uS) This is unclear - what is a "turn on time" and is this in addition to or separate from the underlying enable time of the device? It needs to be clear that this is the ti

[PATCH 2/2] regulator: core: add support for configuring turn-on time through constraints

2013-09-10 Thread Laxman Dewangan
The Turn-ON time of the regulator depends on the regulator device's electrical characteristics. Sometimes regulator turn-on time also depends on the capacitive load on the given platform and it can be more than the datasheet value. The driver provides the enable-time as per datasheet. Add support