Re: [PATCH 2/2] revoke: change revoke_table to fileset and revoke_details

2007-05-03 Thread Pekka J Enberg
On Thu, 3 May 2007, Andrew Morton wrote: > Well that's the "locking" protocol then: each instance of this structure is > only ever touched by a single thread, yes? Yes. Each do_revoke() call creates a new instance. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH 2/2] revoke: change revoke_table to fileset and revoke_details

2007-05-03 Thread Andrew Morton
On Thu, 3 May 2007 23:32:28 +0300 (EEST) Pekka J Enberg <[EMAIL PROTECTED]> wrote: > On Thu, 3 May 2007, Andrew Morton wrote: > > > +/** > > > + * fileset - an array of file pointers. > > > + * @files:the array of file pointers > > > + * @nr: number of elements in the array > > >

Re: [PATCH 2/2] revoke: change revoke_table to fileset and revoke_details

2007-05-03 Thread Pekka J Enberg
On Thu, 3 May 2007, Andrew Morton wrote: > > +/** > > + * fileset - an array of file pointers. > > + * @files:the array of file pointers > > + * @nr: number of elements in the array > > + * @end: index to next unused file pointer > > + */ > > +struct fileset { > > + struct

Re: [PATCH 2/2] revoke: change revoke_table to fileset and revoke_details

2007-05-03 Thread Andrew Morton
On Thu, 3 May 2007 17:53:07 +0300 (EEST) Pekka J Enberg <[EMAIL PROTECTED]> wrote: > From: Pekka Enberg <[EMAIL PROTECTED]> > > The revoke_table struct is overloaded because it serves two purposes: > it manages the pre-allocated set of files and tracks the revoke > operation so that we know where

[PATCH 2/2] revoke: change revoke_table to fileset and revoke_details

2007-05-03 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> The revoke_table struct is overloaded because it serves two purposes: it manages the pre-allocated set of files and tracks the revoke operation so that we know where to start restore if the operation fails. This splits file set management to separate struct f