Re: [PATCH 2/2] riscv/include/uapi: Define a custom __SIGINFO struct for RV32

2019-07-09 Thread Alistair Francis
On Thu, Jul 4, 2019 at 1:34 AM Arnd Bergmann wrote: > > On Thu, Jul 4, 2019 at 12:18 AM Alistair Francis wrote: > > On Wed, Jul 3, 2019 at 12:47 PM Arnd Bergmann wrote: > > > On Wed, Jul 3, 2019 at 8:45 PM Alistair Francis > > > wrote: > > > > What I don't understand though is how that impacte

Re: [PATCH 2/2] riscv/include/uapi: Define a custom __SIGINFO struct for RV32

2019-07-04 Thread Arnd Bergmann
On Thu, Jul 4, 2019 at 12:18 AM Alistair Francis wrote: > On Wed, Jul 3, 2019 at 12:47 PM Arnd Bergmann wrote: > > On Wed, Jul 3, 2019 at 8:45 PM Alistair Francis > > wrote: > > > What I don't understand though is how that impacted this struct, it > > > doesn't use clock_t at all, everything in

Re: [PATCH 2/2] riscv/include/uapi: Define a custom __SIGINFO struct for RV32

2019-07-03 Thread Alistair Francis
On Wed, Jul 3, 2019 at 12:47 PM Arnd Bergmann wrote: > > On Wed, Jul 3, 2019 at 8:45 PM Alistair Francis wrote: > > > > On Wed, Jul 3, 2019 at 1:41 AM Arnd Bergmann wrote: > > > > > > On Wed, Jul 3, 2019 at 2:21 AM Alistair Francis > > > wrote: > > > > > > > > The glibc implementation of siginf

Re: [PATCH 2/2] riscv/include/uapi: Define a custom __SIGINFO struct for RV32

2019-07-03 Thread Arnd Bergmann
On Wed, Jul 3, 2019 at 8:45 PM Alistair Francis wrote: > > On Wed, Jul 3, 2019 at 1:41 AM Arnd Bergmann wrote: > > > > On Wed, Jul 3, 2019 at 2:21 AM Alistair Francis > > wrote: > > > > > > The glibc implementation of siginfo_t results in an allignment of 8 bytes > > > for the union _sifields on

Re: [PATCH 2/2] riscv/include/uapi: Define a custom __SIGINFO struct for RV32

2019-07-03 Thread Alistair Francis
On Wed, Jul 3, 2019 at 1:41 AM Arnd Bergmann wrote: > > On Wed, Jul 3, 2019 at 2:21 AM Alistair Francis > wrote: > > > > The glibc implementation of siginfo_t results in an allignment of 8 bytes > > for the union _sifields on RV32. The kernel has an allignment of 4 bytes > > for the _sifields uni

Re: [PATCH 2/2] riscv/include/uapi: Define a custom __SIGINFO struct for RV32

2019-07-03 Thread Arnd Bergmann
On Wed, Jul 3, 2019 at 2:21 AM Alistair Francis wrote: > > The glibc implementation of siginfo_t results in an allignment of 8 bytes > for the union _sifields on RV32. The kernel has an allignment of 4 bytes > for the _sifields union. This results in information being lost when > glibc parses the

[PATCH 2/2] riscv/include/uapi: Define a custom __SIGINFO struct for RV32

2019-07-02 Thread Alistair Francis
The glibc implementation of siginfo_t results in an allignment of 8 bytes for the union _sifields on RV32. The kernel has an allignment of 4 bytes for the _sifields union. This results in information being lost when glibc parses the siginfo_t struct. To fix the issue add a pad variable to the stru