Re: [PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL

2017-05-04 Thread Alexandre Belloni
On 24/04/2017 at 15:05:12 -0700, Moritz Fischer wrote: > Fix commit 920f91e50c5b ("drivers/rtc/rtc-ds1374.c: add watchdog support") > > The WDIOC_SETOPTIONS case in the watchdog ioctl would alwayss falls > through to the -EINVAL case. This is wrong since thew watchdog does > actually get stopped

Re: [PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL

2017-05-04 Thread Alexandre Belloni
On 24/04/2017 at 15:05:12 -0700, Moritz Fischer wrote: > Fix commit 920f91e50c5b ("drivers/rtc/rtc-ds1374.c: add watchdog support") > > The WDIOC_SETOPTIONS case in the watchdog ioctl would alwayss falls > through to the -EINVAL case. This is wrong since thew watchdog does > actually get stopped

[PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL

2017-04-24 Thread Moritz Fischer
Fix commit 920f91e50c5b ("drivers/rtc/rtc-ds1374.c: add watchdog support") The WDIOC_SETOPTIONS case in the watchdog ioctl would alwayss falls through to the -EINVAL case. This is wrong since thew watchdog does actually get stopped or started correctly. Signed-off-by: Moritz Fischer

[PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL

2017-04-24 Thread Moritz Fischer
Fix commit 920f91e50c5b ("drivers/rtc/rtc-ds1374.c: add watchdog support") The WDIOC_SETOPTIONS case in the watchdog ioctl would alwayss falls through to the -EINVAL case. This is wrong since thew watchdog does actually get stopped or started correctly. Signed-off-by: Moritz Fischer ---