Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-03-01 Thread Krzysztof Kozlowski
On 02.03.2016 11:04, Laxman Dewangan wrote: > > On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: >> On 29.02.2016 21:58, Laxman Dewangan wrote: >>> use macro REGMAP_IRQ_REG from regmap.h to initialise the >>> regmap irq table for max77686. >> Why? Any benefits? >> >> > I think it

Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-03-01 Thread Krzysztof Kozlowski
On 02.03.2016 11:04, Laxman Dewangan wrote: > > On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: >> On 29.02.2016 21:58, Laxman Dewangan wrote: >>> use macro REGMAP_IRQ_REG from regmap.h to initialise the >>> regmap irq table for max77686. >> Why? Any benefits? >> >> > I think it

Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-03-01 Thread Laxman Dewangan
On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: On 29.02.2016 21:58, Laxman Dewangan wrote: use macro REGMAP_IRQ_REG from regmap.h to initialise the regmap irq table for max77686. Why? Any benefits? I think it is better coding to use macro for member initializations instead

Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-03-01 Thread Laxman Dewangan
On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote: On 29.02.2016 21:58, Laxman Dewangan wrote: use macro REGMAP_IRQ_REG from regmap.h to initialise the regmap irq table for max77686. Why? Any benefits? I think it is better coding to use macro for member initializations instead

Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-03-01 Thread Krzysztof Kozlowski
On 29.02.2016 21:58, Laxman Dewangan wrote: > use macro REGMAP_IRQ_REG from regmap.h to initialise the > regmap irq table for max77686. Why? Any benefits? Best regards, Krzysztof > > Signed-off-by: Laxman Dewangan > --- > drivers/rtc/rtc-max77686.c | 12 ++-- >

Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-03-01 Thread Krzysztof Kozlowski
On 29.02.2016 21:58, Laxman Dewangan wrote: > use macro REGMAP_IRQ_REG from regmap.h to initialise the > regmap irq table for max77686. Why? Any benefits? Best regards, Krzysztof > > Signed-off-by: Laxman Dewangan > --- > drivers/rtc/rtc-max77686.c | 12 ++-- > 1 file changed, 6

[PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-02-29 Thread Laxman Dewangan
use macro REGMAP_IRQ_REG from regmap.h to initialise the regmap irq table for max77686. Signed-off-by: Laxman Dewangan --- drivers/rtc/rtc-max77686.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c

[PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-02-29 Thread Laxman Dewangan
use macro REGMAP_IRQ_REG from regmap.h to initialise the regmap irq table for max77686. Signed-off-by: Laxman Dewangan --- drivers/rtc/rtc-max77686.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index