Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-18 Thread Martin Schwidefsky
On Fri, 15 Nov 2013 13:46:07 + Catalin Marinas wrote: > On 15 November 2013 13:29, Martin Schwidefsky wrote: > > On Fri, 15 Nov 2013 11:57:01 + > > Catalin Marinas wrote: > > > >> On Fri, Nov 15, 2013 at 11:17:36AM +, Martin Schwidefsky wrote: > >> > On Fri, 15 Nov 2013 12:10:00 +01

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-15 Thread Catalin Marinas
On 15 November 2013 13:29, Martin Schwidefsky wrote: > On Fri, 15 Nov 2013 11:57:01 + > Catalin Marinas wrote: > >> On Fri, Nov 15, 2013 at 11:17:36AM +, Martin Schwidefsky wrote: >> > On Fri, 15 Nov 2013 12:10:00 +0100 >> > Martin Schwidefsky wrote: >> > >> > > On Fri, 15 Nov 2013 10:44

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-15 Thread Martin Schwidefsky
On Fri, 15 Nov 2013 11:57:01 + Catalin Marinas wrote: > On Fri, Nov 15, 2013 at 11:17:36AM +, Martin Schwidefsky wrote: > > On Fri, 15 Nov 2013 12:10:00 +0100 > > Martin Schwidefsky wrote: > > > > > On Fri, 15 Nov 2013 10:44:37 + > > > Catalin Marinas wrote: > > > > 1. thread-A run

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-15 Thread Catalin Marinas
On Fri, Nov 15, 2013 at 11:17:36AM +, Martin Schwidefsky wrote: > On Fri, 15 Nov 2013 12:10:00 +0100 > Martin Schwidefsky wrote: > > > On Fri, 15 Nov 2013 10:44:37 + > > Catalin Marinas wrote: > > > 1. thread-A running with mm-A > > > 2. context_switch() to thread-B1 causing a switch_mm(

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-15 Thread Martin Schwidefsky
On Fri, 15 Nov 2013 12:10:00 +0100 Martin Schwidefsky wrote: > On Fri, 15 Nov 2013 10:44:37 + > Catalin Marinas wrote: > > > On Thu, Nov 14, 2013 at 04:33:59PM +, Martin Schwidefsky wrote: > > > On Thu, 14 Nov 2013 13:22:23 + > > > Catalin Marinas wrote: > > > > > > > On Thu, Nov

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-15 Thread Martin Schwidefsky
On Fri, 15 Nov 2013 10:44:37 + Catalin Marinas wrote: > On Thu, Nov 14, 2013 at 04:33:59PM +, Martin Schwidefsky wrote: > > On Thu, 14 Nov 2013 13:22:23 + > > Catalin Marinas wrote: > > > > > On Thu, Nov 14, 2013 at 08:10:07AM +, Martin Schwidefsky wrote: > > > > On Wed, 13 Nov

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-15 Thread Catalin Marinas
On Thu, Nov 14, 2013 at 04:33:59PM +, Martin Schwidefsky wrote: > On Thu, 14 Nov 2013 13:22:23 + > Catalin Marinas wrote: > > > On Thu, Nov 14, 2013 at 08:10:07AM +, Martin Schwidefsky wrote: > > > On Wed, 13 Nov 2013 16:16:35 + > > > Catalin Marinas wrote: > > > > > > > On 13 N

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-15 Thread Martin Schwidefsky
On Thu, 14 Nov 2013 09:10:07 +0100 Martin Schwidefsky wrote: > On Wed, 13 Nov 2013 16:16:35 + > Catalin Marinas wrote: > > > On 13 November 2013 08:16, Martin Schwidefsky > > wrote: > > > diff --git a/arch/s390/include/asm/mmu_context.h > > > b/arch/s390/include/asm/mmu_context.h > > > i

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-14 Thread Martin Schwidefsky
On Thu, 14 Nov 2013 13:22:23 + Catalin Marinas wrote: > On Thu, Nov 14, 2013 at 08:10:07AM +, Martin Schwidefsky wrote: > > On Wed, 13 Nov 2013 16:16:35 + > > Catalin Marinas wrote: > > > > > On 13 November 2013 08:16, Martin Schwidefsky > > > wrote: > > > > diff --git a/arch/s390

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-14 Thread Catalin Marinas
On Thu, Nov 14, 2013 at 08:10:07AM +, Martin Schwidefsky wrote: > On Wed, 13 Nov 2013 16:16:35 + > Catalin Marinas wrote: > > > On 13 November 2013 08:16, Martin Schwidefsky > > wrote: > > > diff --git a/arch/s390/include/asm/mmu_context.h > > > b/arch/s390/include/asm/mmu_context.h >

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-14 Thread Martin Schwidefsky
On Wed, 13 Nov 2013 16:16:35 + Catalin Marinas wrote: > On 13 November 2013 08:16, Martin Schwidefsky wrote: > > diff --git a/arch/s390/include/asm/mmu_context.h > > b/arch/s390/include/asm/mmu_context.h > > index 5d1f950..e91afeb 100644 > > --- a/arch/s390/include/asm/mmu_context.h > > +++

Re: [PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-13 Thread Catalin Marinas
On 13 November 2013 08:16, Martin Schwidefsky wrote: > diff --git a/arch/s390/include/asm/mmu_context.h > b/arch/s390/include/asm/mmu_context.h > index 5d1f950..e91afeb 100644 > --- a/arch/s390/include/asm/mmu_context.h > +++ b/arch/s390/include/asm/mmu_context.h > @@ -48,13 +48,38 @@ static inli

[PATCH 2/2] s390/mm,tlb: race of lazy TLB flush vs. recreation of TLB entries

2013-11-13 Thread Martin Schwidefsky
Git commit 050eef364ad70059 "[S390] fix tlb flushing vs. concurrent /proc accesses" introduced the attach counter to avoid using the mm_users value to decide between IPTE for every PTE and lazy TLB flushing with IDTE. That fixed the problem with mm_users but it introduced another subtle race, fortu