Re: [PATCH 2/2] sched/fair: Avoid calling sync_entity_load_avg() unnecessarily

2018-04-27 Thread Quentin Perret
Hi Dietmar, On Friday 27 Apr 2018 at 10:30:39 (+0200), Dietmar Eggemann wrote: > Hi Viresh, > > On 04/26/2018 12:30 PM, Viresh Kumar wrote: > > Call sync_entity_load_avg() directly from find_idlest_cpu() instead of > > select_task_rq_fair(), as that's where we need to use task's utilization > > v

Re: [PATCH 2/2] sched/fair: Avoid calling sync_entity_load_avg() unnecessarily

2018-04-27 Thread Viresh Kumar
Hi Dietmar, On 27-04-18, 10:30, Dietmar Eggemann wrote: > I would suggest we leave the call to sync_entity_load_avg() in the slow path > of strf() so that we're not forced to call it in > find_energy_efficient_cpu(). Well, that's what I did in the very first attempt: https://lkml.kernel.org/r/20

Re: [PATCH 2/2] sched/fair: Avoid calling sync_entity_load_avg() unnecessarily

2018-04-27 Thread Dietmar Eggemann
Hi Viresh, On 04/26/2018 12:30 PM, Viresh Kumar wrote: Call sync_entity_load_avg() directly from find_idlest_cpu() instead of select_task_rq_fair(), as that's where we need to use task's utilization value. And call sync_entity_load_avg() only after making sure sched domain spans over one of the

[PATCH 2/2] sched/fair: Avoid calling sync_entity_load_avg() unnecessarily

2018-04-26 Thread Viresh Kumar
Call sync_entity_load_avg() directly from find_idlest_cpu() instead of select_task_rq_fair(), as that's where we need to use task's utilization value. And call sync_entity_load_avg() only after making sure sched domain spans over one of the allowed CPUs for the task. Signed-off-by: Viresh Kumar -