Re: [PATCH 2/2] sched: trigger_load_balance clean up

2012-09-12 Thread Suresh Siddha
On Wed, 2012-09-12 at 15:58 +0800, Alex Shi wrote: > On 09/12/2012 02:36 AM, Suresh Siddha wrote: > > > On Mon, 2012-09-10 at 15:10 +0800, Alex Shi wrote: > >> Remove a redundant check for on_null_domain(cpu), and rerange the code > >> that make it more readable. > > > > hmm, but we are now doing

Re: [PATCH 2/2] sched: trigger_load_balance clean up

2012-09-12 Thread Alex Shi
On 09/12/2012 02:36 AM, Suresh Siddha wrote: > On Mon, 2012-09-10 at 15:10 +0800, Alex Shi wrote: >> Remove a redundant check for on_null_domain(cpu), and rerange the code >> that make it more readable. > > hmm, but we are now doing the on_null_domain() check always, > irrespective of whether we

Re: [PATCH 2/2] sched: trigger_load_balance clean up

2012-09-11 Thread Suresh Siddha
On Mon, 2012-09-10 at 15:10 +0800, Alex Shi wrote: > Remove a redundant check for on_null_domain(cpu), and rerange the code > that make it more readable. hmm, but we are now doing the on_null_domain() check always, irrespective of whether we need the load balance or not. do we really need the on_

[PATCH 2/2] sched: trigger_load_balance clean up

2012-09-10 Thread Alex Shi
Remove a redundant check for on_null_domain(cpu), and rerange the code that make it more readable. Signed-off-by: Alex Shi --- kernel/sched/fair.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5bbc4bf..529092d 1006