Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-25 Thread Ingo Molnar
* Shuah Khan wrote: > On 02/24/2017 12:45 AM, Ingo Molnar wrote: > > > > * Shuah Khan wrote: > > > >> On 02/23/2017 03:26 PM, Dave Hansen wrote: > >>> Shuah, I assume you'll take this patch in through the selftests tree. > >> > >> Yes I can do that. > > >

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-25 Thread Ingo Molnar
* Shuah Khan wrote: > On 02/24/2017 12:45 AM, Ingo Molnar wrote: > > > > * Shuah Khan wrote: > > > >> On 02/23/2017 03:26 PM, Dave Hansen wrote: > >>> Shuah, I assume you'll take this patch in through the selftests tree. > >> > >> Yes I can do that. > > > > No, let's not do that please, we

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-24 Thread Shuah Khan
On 02/24/2017 12:45 AM, Ingo Molnar wrote: > > * Shuah Khan wrote: > >> On 02/23/2017 03:26 PM, Dave Hansen wrote: >>> Shuah, I assume you'll take this patch in through the selftests tree. >> >> Yes I can do that. > > No, let's not do that please, we have a fix and a

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-24 Thread Shuah Khan
On 02/24/2017 12:45 AM, Ingo Molnar wrote: > > * Shuah Khan wrote: > >> On 02/23/2017 03:26 PM, Dave Hansen wrote: >>> Shuah, I assume you'll take this patch in through the selftests tree. >> >> Yes I can do that. > > No, let's not do that please, we have a fix and a self-tests update, I'd

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-23 Thread Ingo Molnar
* Shuah Khan wrote: > On 02/23/2017 03:26 PM, Dave Hansen wrote: > > Shuah, I assume you'll take this patch in through the selftests tree. > > Yes I can do that. No, let's not do that please, we have a fix and a self-tests update, I'd like them to be next in the Git space.

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-23 Thread Ingo Molnar
* Shuah Khan wrote: > On 02/23/2017 03:26 PM, Dave Hansen wrote: > > Shuah, I assume you'll take this patch in through the selftests tree. > > Yes I can do that. No, let's not do that please, we have a fix and a self-tests update, I'd like them to be next in the Git space. I'll apply the

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-23 Thread Kirill A. Shutemov
On Thu, Feb 23, 2017 at 02:26:04PM -0800, Dave Hansen wrote: > > > Shuah, I assume you'll take this patch in through the selftests tree. > > -- > From: Dave Hansen > > The kernel pkeys code had a minor bug where it did some large shifts > to an integer which is

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-23 Thread Kirill A. Shutemov
On Thu, Feb 23, 2017 at 02:26:04PM -0800, Dave Hansen wrote: > > > Shuah, I assume you'll take this patch in through the selftests tree. > > -- > From: Dave Hansen > > The kernel pkeys code had a minor bug where it did some large shifts > to an integer which is undefined behavior in C. It

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-23 Thread Shuah Khan
On 02/23/2017 03:26 PM, Dave Hansen wrote: > Shuah, I assume you'll take this patch in through the selftests tree. Yes I can do that. -- Shuah > > -- > From: Dave Hansen > > The kernel pkeys code had a minor bug where it did some large shifts > to an integer

Re: [PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-23 Thread Shuah Khan
On 02/23/2017 03:26 PM, Dave Hansen wrote: > Shuah, I assume you'll take this patch in through the selftests tree. Yes I can do that. -- Shuah > > -- > From: Dave Hansen > > The kernel pkeys code had a minor bug where it did some large shifts > to an integer which is undefined behavior in C.

[PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-23 Thread Dave Hansen
Shuah, I assume you'll take this patch in through the selftests tree. -- From: Dave Hansen The kernel pkeys code had a minor bug where it did some large shifts to an integer which is undefined behavior in C. It didn't cause any real harm, but it is screwy

[PATCH 2/2] selftests, x86, pkeys: test with random, unallocated protection keys

2017-02-23 Thread Dave Hansen
Shuah, I assume you'll take this patch in through the selftests tree. -- From: Dave Hansen The kernel pkeys code had a minor bug where it did some large shifts to an integer which is undefined behavior in C. It didn't cause any real harm, but it is screwy behavior that the kernel should have