Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode

2016-10-28 Thread Andy Shevchenko
On Fri, 2016-10-28 at 11:20 +0300, Heikki Krogerus wrote: > Hi Andy, > > On Thu, Oct 27, 2016 at 07:56:10PM +0300, Andy Shevchenko wrote: > > P.S. Use -n when prepare patches to link them if you consider them > > dependent. > > These are numbered? Or do you mean that please prefer sending > serie

Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode

2016-10-28 Thread Heikki Krogerus
Hi Andy, On Thu, Oct 27, 2016 at 07:56:10PM +0300, Andy Shevchenko wrote: > On Thu, 2016-10-27 at 17:38 +0100, Ed Blake wrote: > > Add a set_ldisc function to enable/disable IrDA SIR mode according to > > the new line discipline. > > Thanks for the patch. > > Consider that not all implementation

Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode

2016-10-27 Thread Ed Blake
On 10/27/16 17:56, Andy Shevchenko wrote: On Thu, 2016-10-27 at 17:38 +0100, Ed Blake wrote: Add a set_ldisc function to enable/disable IrDA SIR mode according to the new line discipline. Thanks for the patch. Consider that not all implementations based on 8250_dw support IRDA feature. I suppo

Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode

2016-10-27 Thread Andy Shevchenko
On Thu, 2016-10-27 at 17:38 +0100, Ed Blake wrote: > Add a set_ldisc function to enable/disable IrDA SIR mode according to > the new line discipline. Thanks for the patch. Consider that not all implementations based on 8250_dw support IRDA feature. I suppose you need to read capability register b

[PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode

2016-10-27 Thread Ed Blake
Add a set_ldisc function to enable/disable IrDA SIR mode according to the new line discipline. Signed-off-by: Ed Blake --- drivers/tty/serial/8250/8250_dw.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw