Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-19 Thread Mark Brown
On Wed, Feb 19, 2014 at 02:47:51PM +, One Thousand Gnomes wrote: > > anything to complain that people are following the recommendations of > > the maintainer or to demand that this somehow gets hacked around in > > arch/ when we're trying to convince all the architectures to get their > > driv

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-19 Thread One Thousand Gnomes
> Please try to avoid this sort of misdirected yelling, it's not helping I don't see any misdirected yelling > anything to complain that people are following the recommendations of > the maintainer or to demand that this somehow gets hacked around in > arch/ when we're trying to convince all the

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-19 Thread Mark Brown
On Tue, Feb 18, 2014 at 10:09:43AM +, Etched Pixels wrote: > Mark Brown wrote: > > It's a very real problem which affects actual kernels that distro style > > users are building. > Only because you persist in trying to keep the old static minor > numbers even though they are not needed by an

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-18 Thread One Thousand Gnomes
> > The race isn't the uart code, it's the driver model. > > > > Consider what happens when this happens: > > > > * Two pl011 devices get registered at the same time by two different > > threads. > > How? What two different busses will see this same device? The amba bus > code should prevent

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-18 Thread Etched Pixels
On Tue, 18 Feb 2014 08:50:13 +0900 Mark Brown wrote: > On Mon, Feb 17, 2014 at 03:35:18PM +, One Thousand Gnomes wrote: > > > We've identified a correct working approach which is to simply add a > > CONFIG entry to the ARM tree and a few ifdefs to the problem drivers to > > make the "problem

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-17 Thread Mark Brown
On Mon, Feb 17, 2014 at 03:35:18PM +, One Thousand Gnomes wrote: > We've identified a correct working approach which is to simply add a > CONFIG entry to the ARM tree and a few ifdefs to the problem drivers to > make the "problem" (in fact a complete fictional non-problem) go away and > to get

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-17 Thread One Thousand Gnomes
And an even simpler broad brush approach will also work I think (untested) The "zero crap" approach commit c5cd0be0576ba9059799ef5383402ff6ffc212a3 Author: Alan Date: Mon Feb 17 15:52:21 2014 + tty: Allow serial port allocations to be fully dynamic This switch allows plat

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-17 Thread One Thousand Gnomes
> > How? What two different busses will see this same device? The amba bus > > code should prevent that from happening, right? If not, there's bigger > > problems in that bus code :) > > Where is that requirement documented? It isn't documented. No one > implements any kind of locking at the

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 04:14:36PM -0800, Greg KH wrote: > On Fri, Feb 14, 2014 at 12:07:17AM +, Russell King - ARM Linux wrote: > > On Thu, Feb 13, 2014 at 03:26:06PM -0800, Greg KH wrote: > > > On Thu, Feb 13, 2014 at 06:42:49PM +, Russell King - ARM Linux wrote: > > > > We went through t

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Greg KH
On Fri, Feb 14, 2014 at 12:07:17AM +, Russell King - ARM Linux wrote: > On Thu, Feb 13, 2014 at 03:26:06PM -0800, Greg KH wrote: > > On Thu, Feb 13, 2014 at 06:42:49PM +, Russell King - ARM Linux wrote: > > > We went through this before, and I stated the paths, and no one disagreed > > > wi

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 03:26:06PM -0800, Greg KH wrote: > On Thu, Feb 13, 2014 at 06:42:49PM +, Russell King - ARM Linux wrote: > > We went through this before, and I stated the paths, and no one disagreed > > with that. > > > > It /is/ racy. > > Ok, I just went and looked at the uart driver

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Greg KH
On Thu, Feb 13, 2014 at 06:42:49PM +, Russell King - ARM Linux wrote: > On Thu, Feb 13, 2014 at 10:27:01AM -0800, Greg KH wrote: > > On Thu, Feb 13, 2014 at 06:15:59PM +, Russell King - ARM Linux wrote: > > > On Thu, Feb 13, 2014 at 10:12:16AM -0800, Greg KH wrote: > > > > On Mon, Jan 20, 2

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 10:27:01AM -0800, Greg KH wrote: > On Thu, Feb 13, 2014 at 06:15:59PM +, Russell King - ARM Linux wrote: > > On Thu, Feb 13, 2014 at 10:12:16AM -0800, Greg KH wrote: > > > On Mon, Jan 20, 2014 at 10:04:15AM +, Russell King - ARM Linux wrote: > > > > On Mon, Jan 20, 2

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Greg KH
On Thu, Feb 13, 2014 at 06:15:59PM +, Russell King - ARM Linux wrote: > On Thu, Feb 13, 2014 at 10:12:16AM -0800, Greg KH wrote: > > On Mon, Jan 20, 2014 at 10:04:15AM +, Russell King - ARM Linux wrote: > > > On Mon, Jan 20, 2014 at 02:32:35PM +0530, Tushar Behera wrote: > > > > uart_regist

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 10:12:16AM -0800, Greg KH wrote: > On Mon, Jan 20, 2014 at 10:04:15AM +, Russell King - ARM Linux wrote: > > On Mon, Jan 20, 2014 at 02:32:35PM +0530, Tushar Behera wrote: > > > uart_register_driver call binds the driver to a specific device > > > node through tty_regist

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-02-13 Thread Greg KH
On Mon, Jan 20, 2014 at 10:04:15AM +, Russell King - ARM Linux wrote: > On Mon, Jan 20, 2014 at 02:32:35PM +0530, Tushar Behera wrote: > > uart_register_driver call binds the driver to a specific device > > node through tty_register_driver call. This should typically happen > > during device pr

Re: [PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-01-20 Thread Russell King - ARM Linux
On Mon, Jan 20, 2014 at 02:32:35PM +0530, Tushar Behera wrote: > uart_register_driver call binds the driver to a specific device > node through tty_register_driver call. This should typically happen > during device probe call. > > In a multiplatform scenario, it is possible that multiple serial >

[PATCH 2/2] serial: pl011: Move uart_register_driver call to device probe

2014-01-20 Thread Tushar Behera
uart_register_driver call binds the driver to a specific device node through tty_register_driver call. This should typically happen during device probe call. In a multiplatform scenario, it is possible that multiple serial drivers are part of the kernel. Currently the driver registration fails if