Re: [PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path

2014-03-05 Thread Greg Kroah-Hartman
On Thu, Mar 06, 2014 at 01:19:13PM +0900, Simon Horman wrote: > On Fri, Feb 28, 2014 at 02:21:33PM +0100, Geert Uytterhoeven wrote: > > From: Geert Uytterhoeven > > > > If cpufreq_register_notifier() fails, we have to remove the port added by > > sci_probe_single(), which is not done by

Re: [PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path

2014-03-05 Thread Simon Horman
On Fri, Feb 28, 2014 at 02:21:33PM +0100, Geert Uytterhoeven wrote: > From: Geert Uytterhoeven > > If cpufreq_register_notifier() fails, we have to remove the port added by > sci_probe_single(), which is not done by sci_cleanup_single(). > > Else the serial port stays active from the point of

Re: [PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path

2014-03-05 Thread Simon Horman
On Fri, Feb 28, 2014 at 02:21:33PM +0100, Geert Uytterhoeven wrote: From: Geert Uytterhoeven geert+rene...@linux-m68k.org If cpufreq_register_notifier() fails, we have to remove the port added by sci_probe_single(), which is not done by sci_cleanup_single(). Else the serial port stays

Re: [PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path

2014-03-05 Thread Greg Kroah-Hartman
On Thu, Mar 06, 2014 at 01:19:13PM +0900, Simon Horman wrote: On Fri, Feb 28, 2014 at 02:21:33PM +0100, Geert Uytterhoeven wrote: From: Geert Uytterhoeven geert+rene...@linux-m68k.org If cpufreq_register_notifier() fails, we have to remove the port added by sci_probe_single(), which is

[PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path

2014-02-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven If cpufreq_register_notifier() fails, we have to remove the port added by sci_probe_single(), which is not done by sci_cleanup_single(). Else the serial port stays active from the point of view of the serial subsystem, and it may crash when userspace getty is started,

[PATCH 2/2] serial: sh-sci: Add missing call to uart_remove_one_port() in failure path

2014-02-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven geert+rene...@linux-m68k.org If cpufreq_register_notifier() fails, we have to remove the port added by sci_probe_single(), which is not done by sci_cleanup_single(). Else the serial port stays active from the point of view of the serial subsystem, and it may crash when