Re: [PATCH 2/2] soc: mediatek: Add mt8192 devapc driver

2021-03-29 Thread Nina Wu
Hi, Matthias On Mon, 2021-03-29 at 13:16 +0200, Matthias Brugger wrote: > As a general comment: > > Please split your patch in several, one introducing changes to the existing > code > base which are needed for newer SoCs (depending on the changes more then one) > and one which actually adds

Re: [PATCH 2/2] soc: mediatek: Add mt8192 devapc driver

2021-03-29 Thread Matthias Brugger
As a general comment: Please split your patch in several, one introducing changes to the existing code base which are needed for newer SoCs (depending on the changes more then one) and one which actually adds support for the new SoC. More comments below. On 26/03/2021 08:31, Nina Wu wrote: >

[PATCH 2/2] soc: mediatek: Add mt8192 devapc driver

2021-03-26 Thread Nina Wu
From: Nina Wu The hardware architecture of mt8192 devapc is slightly different from that of the previous IC. We add necessary extensions to support mt8192 and be back-compatible with other ICs. Signed-off-by: Nina Wu --- drivers/soc/mediatek/mtk-devapc.c | 213