Hi,
On Thu, Jul 5, 2018 at 2:46 PM, Girish Mahadevan wrote:
> New driver for Qualcomm QuadSPI(QSPI) controller that is used to
> communicate with slaves such flash memory devices. The QSPI controller
> can operate in 2 or 4 wire mode but only supports SPI Mode 0 and SPI
> Mode 3. The controller c
Hi,
On Thu, Jul 5, 2018 at 2:46 PM, Girish Mahadevan wrote:
> New driver for Qualcomm QuadSPI(QSPI) controller that is used to
> communicate with slaves such flash memory devices. The QSPI controller
> can operate in 2 or 4 wire mode but only supports SPI Mode 0 and SPI
> Mode 3. The controller c
Hi Girish,
On Thu, 5 Jul 2018 15:46:42 -0600
Girish Mahadevan wrote:
> +
> +static int process_data(const struct spi_mem_op *op, struct qcom_qspi *ctrl)
> +{
> + int ret;
> +
> + ctrl->xfer.dir = (op->data.dir == SPI_MEM_DATA_IN) ?
> + QSPI_READ : QSP
On Thu, Jul 05, 2018 at 03:46:42PM -0600, Girish Mahadevan wrote:
Overall this looks pretty good, but there were a few small issues
(mostly cosmetic):
> + /*
> + * Ensure that the configuration goes through by reading back
> + * a register from the IO space.
> + */
> + mb()
New driver for Qualcomm QuadSPI(QSPI) controller that is used to
communicate with slaves such flash memory devices. The QSPI controller
can operate in 2 or 4 wire mode but only supports SPI Mode 0 and SPI
Mode 3. The controller can also operate in Single or Dual data rate modes.
Signed-off-by: Gir
5 matches
Mail list logo
