Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2021-01-05 Thread Geert Uytterhoeven
Hi Pavel, On Tue, Jan 5, 2021 at 11:42 AM Pavel Machek wrote: > > On Tue, Jan 5, 2021 at 12:40 AM Pavel Machek wrote: > > > > > > > .name = "rpc-if-spi", > > > > > > > - .pm = DEV_PM_OPS, > > > > > > > + .pm = _spi_pm_ops, > > > > > > > > >

Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2021-01-05 Thread Pavel Machek
Hi! > On Tue, Jan 5, 2021 at 12:40 AM Pavel Machek wrote: > > > > > > .name = "rpc-if-spi", > > > > > > - .pm = DEV_PM_OPS, > > > > > > + .pm = _spi_pm_ops, > > > > > > > > You're aware rpcif_spi_pm_ops is now always referenced and thus > >

Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2021-01-04 Thread Geert Uytterhoeven
Hi Pavel, On Tue, Jan 5, 2021 at 12:40 AM Pavel Machek wrote: > > > > > .name = "rpc-if-spi", > > > > > - .pm = DEV_PM_OPS, > > > > > + .pm = _spi_pm_ops, > > > > > > You're aware rpcif_spi_pm_ops is now always referenced and thus emitted, >

Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2021-01-04 Thread Pavel Machek
Hi! > > > > .name = "rpc-if-spi", > > > > - .pm = DEV_PM_OPS, > > > > + .pm = _spi_pm_ops, > > > > You're aware rpcif_spi_pm_ops is now always referenced and thus emitted, > > > increasing kernel size by 92 bytes if CONFIG_PM_SLEEP=n? > > >

Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2021-01-04 Thread Lad, Prabhakar
Hi Geert, Thank you for the review. On Mon, Jan 4, 2021 at 12:34 PM Geert Uytterhoeven wrote: > > Hi Prabhakar, > > On Wed, Dec 30, 2020 at 4:00 PM Lad Prabhakar > wrote: > > Use __maybe_unused for the suspend()/resume() hooks and get rid of > > the CONFIG_PM_SLEEP ifdefery to improve the

Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2021-01-04 Thread Mark Brown
On Mon, Jan 04, 2021 at 09:25:17PM +, Lad, Prabhakar wrote: > > > .name = "rpc-if-spi", > > > - .pm = DEV_PM_OPS, > > > + .pm = _spi_pm_ops, > > You're aware rpcif_spi_pm_ops is now always referenced and thus emitted, > > increasing

Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2021-01-04 Thread Geert Uytterhoeven
Hi Prabhakar, On Wed, Dec 30, 2020 at 4:00 PM Lad Prabhakar wrote: > Use __maybe_unused for the suspend()/resume() hooks and get rid of > the CONFIG_PM_SLEEP ifdefery to improve the code. > > Suggested-by: Pavel Machek > Signed-off-by: Lad Prabhakar Thanks for your patch! > ---

Re: [PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2020-12-30 Thread Pavel Machek
On Wed 2020-12-30 14:57:08, Lad Prabhakar wrote: > Use __maybe_unused for the suspend()/resume() hooks and get rid of > the CONFIG_PM_SLEEP ifdefery to improve the code. > > Suggested-by: Pavel Machek Acked-by: Pavel Machek > Signed-off-by: Lad Prabhakar -- DENX Software Engineering GmbH,

[PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2020-12-30 Thread Lad Prabhakar
Use __maybe_unused for the suspend()/resume() hooks and get rid of the CONFIG_PM_SLEEP ifdefery to improve the code. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/spi/spi-rpc-if.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git