Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-08 Thread Baolin Wang
Hi Trent, On 9 August 2018 at 03:08, Trent Piepho wrote: > On Wed, 2018-08-08 at 11:19 +0800, Baolin Wang wrote: >> On 8 August 2018 at 01:10, Trent Piepho wrote: >> > On Tue, 2018-08-07 at 18:43 +0800, Baolin Wang wrote: >> > > >> > > +static u32 sprd_spi_transfer_max_timeout(struct sprd_spi *s

Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-08 Thread Trent Piepho
On Wed, 2018-08-08 at 11:19 +0800, Baolin Wang wrote: > On 8 August 2018 at 01:10, Trent Piepho wrote: > > On Tue, 2018-08-07 at 18:43 +0800, Baolin Wang wrote: > > > > > > +static u32 sprd_spi_transfer_max_timeout(struct sprd_spi *ss, > > > + struct spi_trans

Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-08 Thread Baolin Wang
On 8 August 2018 at 17:31, Mark Brown wrote: > On Wed, Aug 08, 2018 at 10:45:33AM +0800, Baolin Wang wrote: >> On 7 August 2018 at 22:24, Mark Brown wrote: >> > On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote: > >> >> + bits_per_word = bits_per_word > 16 ? round_up(bits_per_word,

Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-08 Thread Mark Brown
On Wed, Aug 08, 2018 at 10:45:33AM +0800, Baolin Wang wrote: > On 7 August 2018 at 22:24, Mark Brown wrote: > > On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote: > >> + bits_per_word = bits_per_word > 16 ? round_up(bits_per_word, 16) : > >> + round_up(bits_per_word, 8);

Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-07 Thread Baolin Wang
Hi Trent, On 8 August 2018 at 01:10, Trent Piepho wrote: > On Tue, 2018-08-07 at 18:43 +0800, Baolin Wang wrote: >> >> +static u32 sprd_spi_transfer_max_timeout(struct sprd_spi *ss, >> + struct spi_transfer *t) >> +{ >> + /* >> + * The time spent on t

Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-07 Thread Baolin Wang
Hi Mark, On 7 August 2018 at 22:24, Mark Brown wrote: > On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote: >> From: Lanqing Liu >> >> This patch adds the SPI controller driver for Spreadtrum SC9860 platform. > > This all looks pretty clean, a few comments below but nothing too major: >

Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-07 Thread Trent Piepho
On Tue, 2018-08-07 at 18:43 +0800, Baolin Wang wrote: > > +static u32 sprd_spi_transfer_max_timeout(struct sprd_spi *ss, > + struct spi_transfer *t) > +{ > + /* > + * The time spent on transmission of the full FIFO data is the maximum > + * SPI tr

Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-07 Thread Mark Brown
On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote: > From: Lanqing Liu > > This patch adds the SPI controller driver for Spreadtrum SC9860 platform. This all looks pretty clean, a few comments below but nothing too major: > +static void sprd_spi_chipselect(struct spi_device *sdev, boo

[PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860

2018-08-07 Thread Baolin Wang
From: Lanqing Liu This patch adds the SPI controller driver for Spreadtrum SC9860 platform. Signed-off-by: Lanqing Liu Signed-off-by: Baolin Wang --- drivers/spi/Kconfig|6 + drivers/spi/Makefile |1 + drivers/spi/spi-sprd.c | 771 +++