On Mon, May 19, 2014 at 12:52 PM, Dan Carpenter
wrote:
>
> You have to understand that I review a lot of staging patches every day.
> Most patches try to remove struct members but the code should still work
> exactly as it did before (a clean up). Some patches remove struct
> members and the
On Mon, May 19, 2014 at 08:57:49AM -0700, David Matlack wrote:
> On Mon, May 19, 2014 at 2:21 AM, Dan Carpenter
> wrote:
> >
> > Looking at the patch, this looks like a bugfix but the changelog doesn't
> > give any clues.
>
> Yeah this isn't a bug fix.
>
> The only member of struct
On Mon, May 19, 2014 at 2:21 AM, Dan Carpenter wrote:
>
> Looking at the patch, this looks like a bugfix but the changelog doesn't
> give any clues.
Yeah this isn't a bug fix.
The only member of struct slic_reg_params that was in use was fail_on_bad_eeprom
(implicitly set to zero by
On Sat, May 17, 2014 at 09:00:04PM -0700, David Matlack wrote:
> Remove uninitialized struct that is only used to regulate whether
> incorrect eeprom checksums are ignored.
>
Looking at the patch, this looks like a bugfix but the changelog doesn't
give any clues.
regards,
dan carpenter
--
To
On Sat, May 17, 2014 at 09:00:04PM -0700, David Matlack wrote:
Remove uninitialized struct that is only used to regulate whether
incorrect eeprom checksums are ignored.
Looking at the patch, this looks like a bugfix but the changelog doesn't
give any clues.
regards,
dan carpenter
--
To
On Mon, May 19, 2014 at 2:21 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
Looking at the patch, this looks like a bugfix but the changelog doesn't
give any clues.
Yeah this isn't a bug fix.
The only member of struct slic_reg_params that was in use was fail_on_bad_eeprom
(implicitly set
On Mon, May 19, 2014 at 08:57:49AM -0700, David Matlack wrote:
On Mon, May 19, 2014 at 2:21 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
Looking at the patch, this looks like a bugfix but the changelog doesn't
give any clues.
Yeah this isn't a bug fix.
The only member of struct
On Mon, May 19, 2014 at 12:52 PM, Dan Carpenter
dan.carpen...@oracle.com wrote:
You have to understand that I review a lot of staging patches every day.
Most patches try to remove struct members but the code should still work
exactly as it did before (a clean up). Some patches remove struct
Remove uninitialized struct that is only used to regulate whether
incorrect eeprom checksums are ignored.
Signed-off-by: David Matlack
---
drivers/staging/slicoss/slic.h| 7 ---
drivers/staging/slicoss/slicoss.c | 3 +--
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git
Remove uninitialized struct that is only used to regulate whether
incorrect eeprom checksums are ignored.
Signed-off-by: David Matlack matlackda...@gmail.com
---
drivers/staging/slicoss/slic.h| 7 ---
drivers/staging/slicoss/slicoss.c | 3 +--
2 files changed, 1 insertion(+), 9
10 matches
Mail list logo
