Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

On Sat, Jun 09, 2007 at 03:49:46PM +0900, Tejun Heo wrote: > Tejun Heo wrote: > > Tejun Heo wrote: > >> Greg KH wrote: > >>> On Mon, May 21, 2007 at 10:31:01AM +0530, Maneesh Soni wrote: > On Thu, May 17, 2007 at 08:16:10PM +0200, Tejun Heo wrote: > > Allowing attribute and symlink dentrie

Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

Tejun Heo wrote: > Tejun Heo wrote: >> Greg KH wrote: >>> On Mon, May 21, 2007 at 10:31:01AM +0530, Maneesh Soni wrote: On Thu, May 17, 2007 at 08:16:10PM +0200, Tejun Heo wrote: > Allowing attribute and symlink dentries to be reclaimed means > sd->s_dentry can change dynamically. How

Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

Tejun Heo wrote: > Greg KH wrote: >> On Mon, May 21, 2007 at 10:31:01AM +0530, Maneesh Soni wrote: >>> On Thu, May 17, 2007 at 08:16:10PM +0200, Tejun Heo wrote: Allowing attribute and symlink dentries to be reclaimed means sd->s_dentry can change dynamically. However, updates to the fie

Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

Greg KH wrote: > On Mon, May 21, 2007 at 10:31:01AM +0530, Maneesh Soni wrote: >> On Thu, May 17, 2007 at 08:16:10PM +0200, Tejun Heo wrote: >>> Allowing attribute and symlink dentries to be reclaimed means >>> sd->s_dentry can change dynamically. However, updates to the field >>> are unsynchroniz

Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

On Mon, May 21, 2007 at 10:31:01AM +0530, Maneesh Soni wrote: > On Thu, May 17, 2007 at 08:16:10PM +0200, Tejun Heo wrote: > > Allowing attribute and symlink dentries to be reclaimed means > > sd->s_dentry can change dynamically. However, updates to the field > > are unsynchronized leading to race

Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

Eric Sandeen wrote: > Maneesh Soni wrote: > >> Looks ok to me.. I have tested it it but unfortunately I couldn't >> recreate the race without the patch also. It would be helpful if >> people actually seeing the race, provide the test results. >> >> Greg, please merge this one once we have some tes

Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

Maneesh Soni wrote: > Looks ok to me.. I have tested it it but unfortunately I couldn't > recreate the race without the patch also. It would be helpful if > people actually seeing the race, provide the test results. > > Greg, please merge this one once we have some test results. I merged this ba

Re: [PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

On Thu, May 17, 2007 at 08:16:10PM +0200, Tejun Heo wrote: > Allowing attribute and symlink dentries to be reclaimed means > sd->s_dentry can change dynamically. However, updates to the field > are unsynchronized leading to race conditions. This patch adds > sysfs_lock and use it to synchronize u

[PATCH 2/2] sysfs: fix race condition around sd->s_dentry, take#2

Allowing attribute and symlink dentries to be reclaimed means sd->s_dentry can change dynamically. However, updates to the field are unsynchronized leading to race conditions. This patch adds sysfs_lock and use it to synchronize updates to sd->s_dentry. Due to the locking around ->d_iput, the ch