Re: [PATCH 2/2] test-hexdump.c: Fix initconst confusion

2015-04-16 Thread Andi Kleen
> > I tried it, but it would have needed a lot more changes to shut up > > warnings later in the code. This was the least intrusive. > > "a lot more changes" is "one more change"? (patch sent) Thanks Geert. You're right of course. -Andi -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 2/2] test-hexdump.c: Fix initconst confusion

2015-04-16 Thread Geert Uytterhoeven
On Thu, Apr 9, 2015 at 1:52 AM, Andi Kleen wrote: > On Wed, Apr 08, 2015 at 03:35:54PM -0700, Andrew Morton wrote: >> > >> > --- a/lib/test-hexdump.c >> > +++ b/lib/test-hexdump.c >> > @@ -18,26 +18,26 @@ static const unsigned char data_b[] = { >> > >> > static const unsigned char data_a[] = ".2.

Re: [PATCH 2/2] test-hexdump.c: Fix initconst confusion

2015-04-08 Thread Andi Kleen
On Wed, Apr 08, 2015 at 03:35:54PM -0700, Andrew Morton wrote: > > > > --- a/lib/test-hexdump.c > > +++ b/lib/test-hexdump.c > > @@ -18,26 +18,26 @@ static const unsigned char data_b[] = { > > > > static const unsigned char data_a[] = ".2.{p..$}.4...1.L...C..."; > > > > -static const

Re: [PATCH 2/2] test-hexdump.c: Fix initconst confusion

2015-04-08 Thread Andrew Morton
On Wed, 8 Apr 2015 06:06:45 -0700 Andi Kleen wrote: > From: Andi Kleen > > const char *...[] is not const, but an array of pointer to const. > So these arrays cannot be __initconst, but must be __initdata > > This fixes section conflicts with LTO. > > --- a/lib/test-hexdump.c > +++ b/lib/te

[PATCH 2/2] test-hexdump.c: Fix initconst confusion

2015-04-08 Thread Andi Kleen
From: Andi Kleen const char *...[] is not const, but an array of pointer to const. So these arrays cannot be __initconst, but must be __initdata This fixes section conflicts with LTO. Signed-off-by: Andi Kleen --- lib/test-hexdump.c | 8 1 file changed, 4 insertions(+), 4 deletions(