Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jarkko Sakkinen
On Tue, Dec 01, 2015 at 10:43:42AM -0700, Jason Gunthorpe wrote: > On Tue, Dec 01, 2015 at 10:35:08AM +0200, Jarkko Sakkinen wrote: > > > In addition I want this fix as a single patch, not as two-patch set. > > The first patch might have made sense when the fix was being developed > > but now

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jason Gunthorpe
On Tue, Dec 01, 2015 at 10:35:08AM +0200, Jarkko Sakkinen wrote: > In addition I want this fix as a single patch, not as two-patch set. > The first patch might have made sense when the fix was being developed > but now it's just really akward change. No, you are not in tune with the kernel

Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jason Gunthorpe
On Tue, Dec 01, 2015 at 12:50:28PM +0100, Wilck, Martin wrote: > The patch introduces one user-visible change, because now the ACPI and > PnP drivers are registered even with "force=1". This causes my TPM to be > show up twice in sysfs: Registering all the drivers is deliberate, IMHO, force

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jason Gunthorpe
On Tue, Dec 01, 2015 at 08:28:35AM +0100, Uwe Kleine-König wrote: > On Mon, Nov 30, 2015 at 12:27:12PM -0700, Jason Gunthorpe wrote: > > The TPM core has long assumed that every device has a driver attached, > > however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks > > are > >

Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Wilck, Martin
On Mo, 2015-11-30 at 12:27 -0700, Jason Gunthorpe wrote: > The TPM core has long assumed that every device has a driver attached, > however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are > called unconditionally") breaks that assumption. > > Rework the TPM setup to create a

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jarkko Sakkinen
Hi On Tue, Dec 01, 2015 at 08:28:35AM +0100, Uwe Kleine-König wrote: > On Mon, Nov 30, 2015 at 12:27:12PM -0700, Jason Gunthorpe wrote: > > The TPM core has long assumed that every device has a driver attached, > > however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks > > are

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jarkko Sakkinen
On Tue, Dec 01, 2015 at 10:43:42AM -0700, Jason Gunthorpe wrote: > On Tue, Dec 01, 2015 at 10:35:08AM +0200, Jarkko Sakkinen wrote: > > > In addition I want this fix as a single patch, not as two-patch set. > > The first patch might have made sense when the fix was being developed > > but now

Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jason Gunthorpe
On Tue, Dec 01, 2015 at 12:50:28PM +0100, Wilck, Martin wrote: > The patch introduces one user-visible change, because now the ACPI and > PnP drivers are registered even with "force=1". This causes my TPM to be > show up twice in sysfs: Registering all the drivers is deliberate, IMHO, force

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jason Gunthorpe
On Tue, Dec 01, 2015 at 10:35:08AM +0200, Jarkko Sakkinen wrote: > In addition I want this fix as a single patch, not as two-patch set. > The first patch might have made sense when the fix was being developed > but now it's just really akward change. No, you are not in tune with the kernel

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jason Gunthorpe
On Tue, Dec 01, 2015 at 08:28:35AM +0100, Uwe Kleine-König wrote: > On Mon, Nov 30, 2015 at 12:27:12PM -0700, Jason Gunthorpe wrote: > > The TPM core has long assumed that every device has a driver attached, > > however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks > > are > >

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Jarkko Sakkinen
Hi On Tue, Dec 01, 2015 at 08:28:35AM +0100, Uwe Kleine-König wrote: > On Mon, Nov 30, 2015 at 12:27:12PM -0700, Jason Gunthorpe wrote: > > The TPM core has long assumed that every device has a driver attached, > > however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks > > are

Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-12-01 Thread Wilck, Martin
On Mo, 2015-11-30 at 12:27 -0700, Jason Gunthorpe wrote: > The TPM core has long assumed that every device has a driver attached, > however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are > called unconditionally") breaks that assumption. > > Rework the TPM setup to create a

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-11-30 Thread Uwe Kleine-König
On Mon, Nov 30, 2015 at 12:27:12PM -0700, Jason Gunthorpe wrote: > The TPM core has long assumed that every device has a driver attached, > however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are > called unconditionally") breaks that assumption. Maybe it's worth to point

[PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-11-30 Thread Jason Gunthorpe
The TPM core has long assumed that every device has a driver attached, however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally") breaks that assumption. Rework the TPM setup to create a platform device with resources and then allow the driver core to

[PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-11-30 Thread Jason Gunthorpe
The TPM core has long assumed that every device has a driver attached, however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally") breaks that assumption. Rework the TPM setup to create a platform device with resources and then allow the driver core to

Re: [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter

2015-11-30 Thread Uwe Kleine-König
On Mon, Nov 30, 2015 at 12:27:12PM -0700, Jason Gunthorpe wrote: > The TPM core has long assumed that every device has a driver attached, > however b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are > called unconditionally") breaks that assumption. Maybe it's worth to point