Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

2017-09-21 Thread Chris Packham
On 21/09/17 19:50, Andy Shevchenko wrote: > On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham > wrote: > > >> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0); >> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, ); >

Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

2017-09-21 Thread Chris Packham
On 21/09/17 19:50, Andy Shevchenko wrote: > On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham > wrote: > > >> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0); >> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, ); > > 0 -> looks like bogus

Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

2017-09-21 Thread Andy Shevchenko
On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham wrote: > -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0); > +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, ); 0 -> looks like bogus checkpatch warning. --

Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

2017-09-21 Thread Andy Shevchenko
On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham wrote: > -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0); > +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, ); 0 -> looks like bogus checkpatch warning. -- With Best Regards, Andy Shevchenko

[PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

2017-09-20 Thread Chris Packham
Add a default compatible string "linux,uio-pdrv-genirq" to uio_pdrv_genirq to make it usable without supplying a module parameter. The module parameter is still supported in addition to the default. Signed-off-by: Chris Packham ---

[PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

2017-09-20 Thread Chris Packham
Add a default compatible string "linux,uio-pdrv-genirq" to uio_pdrv_genirq to make it usable without supplying a module parameter. The module parameter is still supported in addition to the default. Signed-off-by: Chris Packham --- drivers/uio/uio_pdrv_genirq.c | 3 ++- 1 file changed, 2