Re: [PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-12 Thread Greg KH
On Thu, Dec 13, 2012 at 01:08:54AM +0100, Hans J. Koch wrote: > On Wed, Dec 12, 2012 at 07:08:18AM -0800, Greg KH wrote: > > On Wed, Dec 12, 2012 at 09:56:16AM +0100, Benedikt Spranger wrote: > > > Am Wed, 12 Dec 2012 09:50:54 +0100 > > > schrieb "Hans J. Koch" : > > > > > > > On Tue, Dec 11, 2012

Re: [PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-12 Thread Hans J. Koch
On Wed, Dec 12, 2012 at 07:08:18AM -0800, Greg KH wrote: > On Wed, Dec 12, 2012 at 09:56:16AM +0100, Benedikt Spranger wrote: > > Am Wed, 12 Dec 2012 09:50:54 +0100 > > schrieb "Hans J. Koch" : > > > > > On Tue, Dec 11, 2012 at 08:46:48PM -0800, Greg KH wrote: > > > > Yes, but what does that have

Re: [PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-12 Thread Greg KH
On Wed, Dec 12, 2012 at 09:56:16AM +0100, Benedikt Spranger wrote: > Am Wed, 12 Dec 2012 09:50:54 +0100 > schrieb "Hans J. Koch" : > > > On Tue, Dec 11, 2012 at 08:46:48PM -0800, Greg KH wrote: > > > Yes, but what does that have to do with this in-kernel, internal api? > > > > Ah, OK. You're righ

Re: [PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-12 Thread Benedikt Spranger
Am Wed, 12 Dec 2012 09:50:54 +0100 schrieb "Hans J. Koch" : > On Tue, Dec 11, 2012 at 08:46:48PM -0800, Greg KH wrote: > > Yes, but what does that have to do with this in-kernel, internal api? > > Ah, OK. You're right, the commit message is confusing. > > Bene, it's enough to say we drop the ino

Re: [PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-12 Thread Hans J. Koch
On Tue, Dec 11, 2012 at 08:46:48PM -0800, Greg KH wrote: > On Wed, Dec 12, 2012 at 02:42:22AM +0100, Hans J. Koch wrote: > > On Tue, Dec 11, 2012 at 03:20:32PM -0800, Greg KH wrote: > > > On Wed, Dec 12, 2012 at 12:12:02AM +0100, Benedikt Spranger wrote: > > > > The inode parameter is unused by in

Re: [PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-11 Thread Greg KH
On Wed, Dec 12, 2012 at 02:42:22AM +0100, Hans J. Koch wrote: > On Tue, Dec 11, 2012 at 03:20:32PM -0800, Greg KH wrote: > > On Wed, Dec 12, 2012 at 12:12:02AM +0100, Benedikt Spranger wrote: > > > The inode parameter is unused by in kernel users of UIO. > > > > Ok. > > > > > Also the inode param

Re: [PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-11 Thread Hans J. Koch
On Tue, Dec 11, 2012 at 03:20:32PM -0800, Greg KH wrote: > On Wed, Dec 12, 2012 at 12:12:02AM +0100, Benedikt Spranger wrote: > > The inode parameter is unused by in kernel users of UIO. > > Ok. > > > Also the inode parameter makes it hard to resolve the existing open(), > > mmap() and close() di

Re: [PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-11 Thread Greg KH
On Wed, Dec 12, 2012 at 12:12:02AM +0100, Benedikt Spranger wrote: > The inode parameter is unused by in kernel users of UIO. Ok. > Also the inode parameter makes it hard to resolve the existing open(), > mmap() and close() difficulty. I don't understand, what do you mean by this? What is this

[PATCH 2/2] uio: do not expose inode to uio open/release hooks

2012-12-11 Thread Benedikt Spranger
The inode parameter is unused by in kernel users of UIO. Also the inode parameter makes it hard to resolve the existing open(), mmap() and close() difficulty. Signed-off-by: Benedikt Spranger --- Documentation/DocBook/uio-howto.tmpl |4 ++-- drivers/uio/uio.c|4 ++--