Re: [PATCH 2/2] usb: misc: usb5744: Add support for USB hub controller

2021-02-10 Thread Michal Simek
Hi Andrew, On 2/10/21 3:52 AM, Andrew Lunn wrote: > On Tue, Feb 09, 2021 at 10:53:20AM +0100, Michal Simek wrote: >> +static int usb5744_i2c_probe(struct i2c_client *client, >> + const struct i2c_device_id *id) >> +{ >> +struct device *dev = &client->dev; >> +int re

Re: [PATCH 2/2] usb: misc: usb5744: Add support for USB hub controller

2021-02-09 Thread Andrew Lunn
On Tue, Feb 09, 2021 at 10:53:20AM +0100, Michal Simek wrote: > +static int usb5744_i2c_probe(struct i2c_client *client, > + const struct i2c_device_id *id) > +{ > + struct device *dev = &client->dev; > + int ret; > + > + /* Trigger gpio reset to the hub. */ > +

Re: [PATCH 2/2] usb: misc: usb5744: Add support for USB hub controller

2021-02-09 Thread Greg Kroah-Hartman
On Tue, Feb 09, 2021 at 11:11:54AM +0100, Michal Simek wrote: > > > On 2/9/21 11:03 AM, Greg Kroah-Hartman wrote: > > On Tue, Feb 09, 2021 at 10:53:20AM +0100, Michal Simek wrote: > >> From: Piyush Mehta > >> > >> This patch adds a USB GPIO based hub reset for USB5744 hub. This usb5744 > >> driv

Re: [PATCH 2/2] usb: misc: usb5744: Add support for USB hub controller

2021-02-09 Thread Michal Simek
On 2/9/21 11:03 AM, Greg Kroah-Hartman wrote: > On Tue, Feb 09, 2021 at 10:53:20AM +0100, Michal Simek wrote: >> From: Piyush Mehta >> >> This patch adds a USB GPIO based hub reset for USB5744 hub. This usb5744 >> driver trigger hub reset signal after soft reset or core Reset. The HUB >> needs

Re: [PATCH 2/2] usb: misc: usb5744: Add support for USB hub controller

2021-02-09 Thread Greg Kroah-Hartman
On Tue, Feb 09, 2021 at 10:53:20AM +0100, Michal Simek wrote: > From: Piyush Mehta > > This patch adds a USB GPIO based hub reset for USB5744 hub. This usb5744 > driver trigger hub reset signal after soft reset or core Reset. The HUB > needs to be resetted after completion of phy initialization.

[PATCH 2/2] usb: misc: usb5744: Add support for USB hub controller

2021-02-09 Thread Michal Simek
From: Piyush Mehta This patch adds a USB GPIO based hub reset for USB5744 hub. This usb5744 driver trigger hub reset signal after soft reset or core Reset. The HUB needs to be resetted after completion of phy initialization. After the toggling of gpio, hub configure using i2c usb attached command