[PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing

2017-10-03 Thread Mateusz Guzik
Explicit locking in the fallback case provides a safe state of the table. Getting rid of blocking semantics makes __fd_install usable again in non-sleepable contexts, which easies backporting efforts. There is a side effect of slightly nicer assembly for the common case as might_sleep can now be r

Re: [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing

2017-10-03 Thread Eric Dumazet
On Tue, Oct 3, 2017 at 3:58 AM, Mateusz Guzik wrote: > Explicit locking in the fallback case provides a safe state of the > table. Getting rid of blocking semantics makes __fd_install usable > again in non-sleepable contexts, which easies backporting efforts. > > There is a side effect of slightly

Re: [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing

2017-10-04 Thread Matthew Wilcox
On Tue, Oct 03, 2017 at 07:41:11AM -0700, Eric Dumazet wrote: > On Tue, Oct 3, 2017 at 3:58 AM, Mateusz Guzik wrote: > > Explicit locking in the fallback case provides a safe state of the > > table. Getting rid of blocking semantics makes __fd_install usable > > again in non-sleepable contexts, wh

Re: [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing

2017-10-04 Thread Eric Dumazet
On Wed, Oct 4, 2017 at 6:55 AM, Matthew Wilcox wrote: > On Tue, Oct 03, 2017 at 07:41:11AM -0700, Eric Dumazet wrote: >> On Tue, Oct 3, 2017 at 3:58 AM, Mateusz Guzik wrote: >> > Explicit locking in the fallback case provides a safe state of the >> > table. Getting rid of blocking semantics makes

Re: [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing

2017-10-04 Thread Matthew Wilcox
On Wed, Oct 04, 2017 at 07:00:40AM -0700, Eric Dumazet wrote: > On Wed, Oct 4, 2017 at 6:55 AM, Matthew Wilcox wrote: > > Any chance you could review the patches from Sandhya that make this entire > > codepath obsolete? > > > > https://lkml.org/lkml/2017/4/29/20 > > > > Hmm... > > 18 files chang

Re: [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing

2017-10-04 Thread Eric Dumazet
On Wed, Oct 4, 2017 at 7:58 AM, Matthew Wilcox wrote: > On Wed, Oct 04, 2017 at 07:00:40AM -0700, Eric Dumazet wrote: >> On Wed, Oct 4, 2017 at 6:55 AM, Matthew Wilcox wrote: >> > Any chance you could review the patches from Sandhya that make this entire >> > codepath obsolete? >> > >> > https://