Re: [PATCH 2/2] virtio: delete napi structures from netdev before releasing memory

2013-12-06 Thread Rusty Russell
Jason Wang writes: > On 12/05/2013 10:36 PM, Andrey Vagin wrote: >> free_netdev calls netif_napi_del too, but it's too late, because napi >> structures are placed on vi->rq. netif_napi_add() is called from >> virtnet_alloc_queues. >> >> general protection fault: [#1] SMP >> Dumping ftrace buf

Re: [PATCH 2/2] virtio: delete napi structures from netdev before releasing memory

2013-12-06 Thread David Miller
From: Andrey Vagin Date: Thu, 5 Dec 2013 18:36:21 +0400 > free_netdev calls netif_napi_del too, but it's too late, because napi > structures are placed on vi->rq. netif_napi_add() is called from > virtnet_alloc_queues. ... > Fixes: 986a4f4d452d (virtio_net: multiqueue support) > Cc: Rusty Russe

Re: [PATCH 2/2] virtio: delete napi structures from netdev before releasing memory

2013-12-05 Thread Jason Wang
On 12/05/2013 10:36 PM, Andrey Vagin wrote: > free_netdev calls netif_napi_del too, but it's too late, because napi > structures are placed on vi->rq. netif_napi_add() is called from > virtnet_alloc_queues. > > general protection fault: [#1] SMP > Dumping ftrace buffer: >(ftrace buffer emp

Re: [PATCH 2/2] virtio: delete napi structures from netdev before releasing memory

2013-12-05 Thread Michael S. Tsirkin
On Thu, Dec 05, 2013 at 06:36:21PM +0400, Andrey Vagin wrote: > free_netdev calls netif_napi_del too, but it's too late, because napi > structures are placed on vi->rq. netif_napi_add() is called from > virtnet_alloc_queues. > > general protection fault: [#1] SMP > Dumping ftrace buffer: >

[PATCH 2/2] virtio: delete napi structures from netdev before releasing memory

2013-12-05 Thread Andrey Vagin
free_netdev calls netif_napi_del too, but it's too late, because napi structures are placed on vi->rq. netif_napi_add() is called from virtnet_alloc_queues. general protection fault: [#1] SMP Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: ip6table_filter ip6_tables iptable