Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-11-01 Thread Jens Axboe
On 11/01/2013 10:45 AM, Christoph Hellwig wrote: > Updated version to address Asias' comments and rebased ontop of > block/for-next with the immutable bio changes: Thanks, I updated the blk-mq/drivers branch to have the for-3.13/core immutable changes and replaced the existing virtio-blk patch.

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-11-01 Thread Christoph Hellwig
Updated version to address Asias' comments and rebased ontop of block/for-next with the immutable bio changes: --- From: Jens Axboe Subject: virtio_blk: blk-mq support Switch virtio-blk from the dual support for old-style requests and bios to use the block-multiqueue. Acked-by: Asias

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-11-01 Thread Christoph Hellwig
Updated version to address Asias' comments and rebased ontop of block/for-next with the immutable bio changes: --- From: Jens Axboe ax...@kernel.dk Subject: virtio_blk: blk-mq support Switch virtio-blk from the dual support for old-style requests and bios to use the block-multiqueue.

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-11-01 Thread Jens Axboe
On 11/01/2013 10:45 AM, Christoph Hellwig wrote: Updated version to address Asias' comments and rebased ontop of block/for-next with the immutable bio changes: Thanks, I updated the blk-mq/drivers branch to have the for-3.13/core immutable changes and replaced the existing virtio-blk patch. --

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-30 Thread Asias He
Hello Jens, On Tue, Oct 29, 2013 at 03:34:01PM -0600, Jens Axboe wrote: > On 10/28/2013 02:52 AM, Christoph Hellwig wrote: > > On Mon, Oct 28, 2013 at 01:17:54PM +1030, Rusty Russell wrote: > >> Let's pretend I'm stupid. > >> > >> We don't actually have multiple queues through to the host, but

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-30 Thread Asias He
Hello Jens, On Tue, Oct 29, 2013 at 03:34:01PM -0600, Jens Axboe wrote: On 10/28/2013 02:52 AM, Christoph Hellwig wrote: On Mon, Oct 28, 2013 at 01:17:54PM +1030, Rusty Russell wrote: Let's pretend I'm stupid. We don't actually have multiple queues through to the host, but we're

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-29 Thread Jens Axboe
On 10/28/2013 02:52 AM, Christoph Hellwig wrote: > On Mon, Oct 28, 2013 at 01:17:54PM +1030, Rusty Russell wrote: >> Let's pretend I'm stupid. >> >> We don't actually have multiple queues through to the host, but we're >> pretending to, because it makes the block layer go faster? >> >> Do I want

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-29 Thread Jens Axboe
On 10/28/2013 02:52 AM, Christoph Hellwig wrote: On Mon, Oct 28, 2013 at 01:17:54PM +1030, Rusty Russell wrote: Let's pretend I'm stupid. We don't actually have multiple queues through to the host, but we're pretending to, because it makes the block layer go faster? Do I want to know *why*

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-28 Thread Christoph Hellwig
On Mon, Oct 28, 2013 at 01:17:54PM +1030, Rusty Russell wrote: > Let's pretend I'm stupid. > > We don't actually have multiple queues through to the host, but we're > pretending to, because it makes the block layer go faster? > > Do I want to know *why* it's faster? Or should I look the other

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-28 Thread Christoph Hellwig
On Mon, Oct 28, 2013 at 01:17:54PM +1030, Rusty Russell wrote: Let's pretend I'm stupid. We don't actually have multiple queues through to the host, but we're pretending to, because it makes the block layer go faster? Do I want to know *why* it's faster? Or should I look the other way?

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-27 Thread Rusty Russell
Christoph Hellwig writes: > Switch virtio-blk from the dual support for old-style requests and bios > to use the block-multiqueue. For now pretend to have 4 issue queues > as Jens pulled that out of his this hair and it worked. Let's pretend I'm stupid. We don't actually have multiple queues

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-27 Thread Rusty Russell
Christoph Hellwig h...@infradead.org writes: Switch virtio-blk from the dual support for old-style requests and bios to use the block-multiqueue. For now pretend to have 4 issue queues as Jens pulled that out of his this hair and it worked. Let's pretend I'm stupid. We don't actually have

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Asias He
On Fri, Oct 25, 2013 at 06:05:01AM -0700, Christoph Hellwig wrote: > Switch virtio-blk from the dual support for old-style requests and bios > to use the block-multiqueue. For now pretend to have 4 issue queues > as Jens pulled that out of his this hair and it worked. > > Signed-off-by: Jens

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Jens Axboe
On Fri, Oct 25 2013, Christoph Hellwig wrote: > Switch virtio-blk from the dual support for old-style requests and bios > to use the block-multiqueue. For now pretend to have 4 issue queues > as Jens pulled that out of his this hair and it worked. Updated the blk-mq/drivers to carry this

[PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Christoph Hellwig
Switch virtio-blk from the dual support for old-style requests and bios to use the block-multiqueue. For now pretend to have 4 issue queues as Jens pulled that out of his this hair and it worked. Signed-off-by: Jens Axboe Signed-off-by: Christoph Hellwig --- drivers/block/virtio_blk.c | 312

[PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Christoph Hellwig
Switch virtio-blk from the dual support for old-style requests and bios to use the block-multiqueue. For now pretend to have 4 issue queues as Jens pulled that out of his this hair and it worked. Signed-off-by: Jens Axboe ax...@kernel.dk Signed-off-by: Christoph Hellwig h...@lst.de ---

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Jens Axboe
On Fri, Oct 25 2013, Christoph Hellwig wrote: Switch virtio-blk from the dual support for old-style requests and bios to use the block-multiqueue. For now pretend to have 4 issue queues as Jens pulled that out of his this hair and it worked. Updated the blk-mq/drivers to carry this version.

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Asias He
On Fri, Oct 25, 2013 at 06:05:01AM -0700, Christoph Hellwig wrote: Switch virtio-blk from the dual support for old-style requests and bios to use the block-multiqueue. For now pretend to have 4 issue queues as Jens pulled that out of his this hair and it worked. Signed-off-by: Jens Axboe