Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-05 Thread Ingo Molnar
* Josh Triplett wrote: > On Thu, Jun 04, 2015 at 12:07:31PM +0200, Denys Vlasenko wrote: > > On 06/03/2015 06:38 PM, Josh Triplett wrote: > > > On Wed, Jun 03, 2015 at 03:58:50PM +0200, Denys Vlasenko wrote: > > >> Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" > > >>

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-05 Thread Ingo Molnar
* Josh Triplett j...@joshtriplett.org wrote: On Thu, Jun 04, 2015 at 12:07:31PM +0200, Denys Vlasenko wrote: On 06/03/2015 06:38 PM, Josh Triplett wrote: On Wed, Jun 03, 2015 at 03:58:50PM +0200, Denys Vlasenko wrote: Really swap arguments #4 and #5 in stub32_clone instead of optimizing

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-04 Thread Josh Triplett
On Thu, Jun 04, 2015 at 12:07:31PM +0200, Denys Vlasenko wrote: > On 06/03/2015 06:38 PM, Josh Triplett wrote: > > On Wed, Jun 03, 2015 at 03:58:50PM +0200, Denys Vlasenko wrote: > >> Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" > >> it into a move. > >> > >> Yes,

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-04 Thread Denys Vlasenko
On 06/03/2015 06:38 PM, Josh Triplett wrote: > On Wed, Jun 03, 2015 at 03:58:50PM +0200, Denys Vlasenko wrote: >> Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" >> it into a move. >> >> Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit >> more

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-04 Thread Josh Triplett
On Thu, Jun 04, 2015 at 12:07:31PM +0200, Denys Vlasenko wrote: On 06/03/2015 06:38 PM, Josh Triplett wrote: On Wed, Jun 03, 2015 at 03:58:50PM +0200, Denys Vlasenko wrote: Really swap arguments #4 and #5 in stub32_clone instead of optimizing it into a move. Yes, tls_val is currently

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-04 Thread Denys Vlasenko
On 06/03/2015 06:38 PM, Josh Triplett wrote: On Wed, Jun 03, 2015 at 03:58:50PM +0200, Denys Vlasenko wrote: Really swap arguments #4 and #5 in stub32_clone instead of optimizing it into a move. Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit more expensive than MOV.

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-03 Thread Josh Triplett
On Wed, Jun 03, 2015 at 03:58:50PM +0200, Denys Vlasenko wrote: > Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" > it into a move. > > Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit > more expensive than MOV. But a cycle or two on an expensive

[PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-03 Thread Denys Vlasenko
Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" it into a move. Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit more expensive than MOV. But a cycle or two on an expensive syscall like clone() is way below noise floor, and this optimization is

[PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-03 Thread Denys Vlasenko
Really swap arguments #4 and #5 in stub32_clone instead of optimizing it into a move. Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit more expensive than MOV. But a cycle or two on an expensive syscall like clone() is way below noise floor, and this optimization is simply

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-06-03 Thread Josh Triplett
On Wed, Jun 03, 2015 at 03:58:50PM +0200, Denys Vlasenko wrote: Really swap arguments #4 and #5 in stub32_clone instead of optimizing it into a move. Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit more expensive than MOV. But a cycle or two on an expensive syscall

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-23 Thread Josh Triplett
On Thu, Apr 23, 2015 at 08:24:38AM +0200, Ingo Molnar wrote: > * Josh Triplett wrote: > > On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: > > > On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett > > > wrote: > > > > > > > > I do think my two-patch HAVE_COPY_THREAD_TLS series should

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-23 Thread Ingo Molnar
* Josh Triplett wrote: > On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: > > On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett > > wrote: > > > > > > I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing > > > this > > > > Ugh, I absolutely detesrt that patch.

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-23 Thread Ingo Molnar
* Josh Triplett j...@joshtriplett.org wrote: On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett j...@joshtriplett.org wrote: I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing this Ugh, I

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-23 Thread Josh Triplett
On Thu, Apr 23, 2015 at 08:24:38AM +0200, Ingo Molnar wrote: * Josh Triplett j...@joshtriplett.org wrote: On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett j...@joshtriplett.org wrote: I do think my two-patch

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Josh Triplett
On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: > On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett wrote: > > > > I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing > > this > > Ugh, I absolutely detesrt that patch. > > Don't make random crazy function

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Linus Torvalds
On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett wrote: > > I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing > this Ugh, I absolutely detesrt that patch. Don't make random crazy function signatures that depend on some config option. That's just evil. The patch is a mess of

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Denys Vlasenko
On 04/22/2015 07:10 PM, Josh Triplett wrote: > On Wed, Apr 22, 2015 at 09:54:24AM -0700, Andy Lutomirski wrote: >> On Wed, Apr 22, 2015 at 9:40 AM, Denys Vlasenko wrote: >>> Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" >>> it into a move. >>> >>> Yes, tls_val is

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Josh Triplett
On Wed, Apr 22, 2015 at 09:54:24AM -0700, Andy Lutomirski wrote: > On Wed, Apr 22, 2015 at 9:40 AM, Denys Vlasenko wrote: > > Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" > > it into a move. > > > > Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Andy Lutomirski
On Wed, Apr 22, 2015 at 9:40 AM, Denys Vlasenko wrote: > Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" > it into a move. > > Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit > more expensive than MOV. But a cycle or two on an expensive syscall

[PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Denys Vlasenko
Really swap arguments #4 and #5 in stub32_clone instead of "optimizing" it into a move. Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit more expensive than MOV. But a cycle or two on an expensive syscall like clone() is way below noise floor, and obfuscation of logic

[PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Denys Vlasenko
Really swap arguments #4 and #5 in stub32_clone instead of optimizing it into a move. Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit more expensive than MOV. But a cycle or two on an expensive syscall like clone() is way below noise floor, and obfuscation of logic

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Andy Lutomirski
On Wed, Apr 22, 2015 at 9:40 AM, Denys Vlasenko dvlas...@redhat.com wrote: Really swap arguments #4 and #5 in stub32_clone instead of optimizing it into a move. Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a little bit more expensive than MOV. But a cycle or two on an expensive

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Josh Triplett
On Wed, Apr 22, 2015 at 09:54:24AM -0700, Andy Lutomirski wrote: On Wed, Apr 22, 2015 at 9:40 AM, Denys Vlasenko dvlas...@redhat.com wrote: Really swap arguments #4 and #5 in stub32_clone instead of optimizing it into a move. Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Denys Vlasenko
On 04/22/2015 07:10 PM, Josh Triplett wrote: On Wed, Apr 22, 2015 at 09:54:24AM -0700, Andy Lutomirski wrote: On Wed, Apr 22, 2015 at 9:40 AM, Denys Vlasenko dvlas...@redhat.com wrote: Really swap arguments #4 and #5 in stub32_clone instead of optimizing it into a move. Yes, tls_val is

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Linus Torvalds
On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett j...@joshtriplett.org wrote: I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing this Ugh, I absolutely detesrt that patch. Don't make random crazy function signatures that depend on some config option. That's just evil. The

Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone

2015-04-22 Thread Josh Triplett
On Wed, Apr 22, 2015 at 11:22:02AM -0700, Linus Torvalds wrote: On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett j...@joshtriplett.org wrote: I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing this Ugh, I absolutely detesrt that patch. Don't make random crazy