Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data

2021-02-24 Thread Josh Poimboeuf
On Wed, Feb 24, 2021 at 07:07:31PM +0100, Peter Zijlstra wrote: > On Wed, Feb 24, 2021 at 09:18:05AM -0600, Josh Poimboeuf wrote: > > On Wed, Feb 24, 2021 at 03:52:01PM +0100, Peter Zijlstra wrote: > > > On Fri, Feb 05, 2021 at 08:24:03AM -0600, Josh Poimboeuf wrote: > > > > The ORC unwinder attemp

Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data

2021-02-24 Thread Peter Zijlstra
On Wed, Feb 24, 2021 at 09:18:05AM -0600, Josh Poimboeuf wrote: > On Wed, Feb 24, 2021 at 03:52:01PM +0100, Peter Zijlstra wrote: > > On Fri, Feb 05, 2021 at 08:24:03AM -0600, Josh Poimboeuf wrote: > > > The ORC unwinder attempts to fall back to frame pointers when ORC data > > > is missing for a g

Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data

2021-02-24 Thread Josh Poimboeuf
On Wed, Feb 24, 2021 at 03:52:01PM +0100, Peter Zijlstra wrote: > On Fri, Feb 05, 2021 at 08:24:03AM -0600, Josh Poimboeuf wrote: > > The ORC unwinder attempts to fall back to frame pointers when ORC data > > is missing for a given instruction. It sets state->error, but then > > tries to keep goin

Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data

2021-02-24 Thread Peter Zijlstra
On Fri, Feb 05, 2021 at 08:24:03AM -0600, Josh Poimboeuf wrote: > The ORC unwinder attempts to fall back to frame pointers when ORC data > is missing for a given instruction. It sets state->error, but then > tries to keep going as a best-effort type of thing. That may result in > further warnings

Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data

2021-02-08 Thread Ivan Babrou
On Mon, Feb 8, 2021 at 11:56 AM Josh Poimboeuf wrote: > > On Fri, Feb 05, 2021 at 08:24:03AM -0600, Josh Poimboeuf wrote: > > The ORC unwinder attempts to fall back to frame pointers when ORC data > > is missing for a given instruction. It sets state->error, but then > > tries to keep going as a

Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data

2021-02-08 Thread Josh Poimboeuf
On Fri, Feb 05, 2021 at 08:24:03AM -0600, Josh Poimboeuf wrote: > The ORC unwinder attempts to fall back to frame pointers when ORC data > is missing for a given instruction. It sets state->error, but then > tries to keep going as a best-effort type of thing. That may result in > further warnings

[PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data

2021-02-05 Thread Josh Poimboeuf
The ORC unwinder attempts to fall back to frame pointers when ORC data is missing for a given instruction. It sets state->error, but then tries to keep going as a best-effort type of thing. That may result in further warnings if the unwinder gets lost. Until we have some way to register generate