Re: [PATCH 2/2] x86: Useless inode var and Coding style fixes

2013-09-17 Thread Joe Perches
On Tue, 2013-09-17 at 23:54 -0300, Geyslan G. Bem wrote: > Coding style and printk strings fixes. [] > diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c [] > @@ -299,12 +301,12 @@ static int load_aout_binary(struct linux_binprm * bprm) > > if ((fd_offset & ~PAGE_MASK) != 0 && printk_

[PATCH 2/2] x86: Useless inode var and Coding style fixes

2013-09-17 Thread Geyslan G. Bem
file size read only one time: useless prior value allocation. It's not necessary to verify f_op in the load_aout_library, since the prior kernel_read/vfs_read function already does. Coding style and printk strings fixes. Tested using qemu, a handcrafted a.out binary and a a.out linked with a cross

Re: [PATCH 2/2] x86: Useless inode var and Coding style fixes

2013-09-17 Thread H. Peter Anvin
On 09/17/2013 07:22 PM, Geyslan G. Bem wrote: > file size read only one time: useless prior value allocation. > It's not necessary to verify f_op in the load_aout_library, since the > prior kernel_read/vfs_read function already does. > Coding style and printk strings fixes. > > Tested using qemu,

[PATCH 2/2] x86: Useless inode var and Coding style fixes

2013-09-17 Thread Geyslan G. Bem
file size read only one time: useless prior value allocation. It's not necessary to verify f_op in the load_aout_library, since the prior kernel_read/vfs_read function already does. Coding style and printk strings fixes. Tested using qemu, a handcrafted a.out binary and a a.out linked with a cross