Re: [PATCH 2/2] x86: iosf: Add debugfs support

2014-08-27 Thread H. Peter Anvin
On 08/27/2014 02:40 PM, David E. Box wrote: > Allows access to the iosf sideband through debugfs. This would break if compiled without CONFIG_DEBUGFS support, which is often a requirement for security reasons. Please conditionalize this code, and if practical move it to a separate .c file. Most

[PATCH 2/2] x86: iosf: Add debugfs support

2014-08-27 Thread David E. Box
Allows access to the iosf sideband through debugfs. Signed-off-by: David E. Box --- arch/x86/kernel/iosf_mbi.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c index d30acdc..bf848ca

[PATCH 2/2] x86: iosf: Add debugfs support

2014-08-27 Thread David E. Box
Allows access to the iosf sideband through debugfs. Signed-off-by: David E. Box david.e@linux.intel.com --- arch/x86/kernel/iosf_mbi.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c

Re: [PATCH 2/2] x86: iosf: Add debugfs support

2014-08-27 Thread H. Peter Anvin
On 08/27/2014 02:40 PM, David E. Box wrote: Allows access to the iosf sideband through debugfs. This would break if compiled without CONFIG_DEBUGFS support, which is often a requirement for security reasons. Please conditionalize this code, and if practical move it to a separate .c file. Most