Re: [PATCH 2/2] x86: kvm: avoid constant-conversion warning

2019-07-12 Thread Paolo Bonzini
On 12/07/19 11:12, Arnd Bergmann wrote: > clang finds a contruct suspicious that converts an unsigned > character to a signed integer and back, causing an overflow: I like how the commit message conveys the braindead-ness of the warning. Queued, thanks. Paolo > arch/x86/kvm/mmu.c:4605:39: error

Re: [PATCH 2/2] x86: kvm: avoid constant-conversion warning

2019-07-12 Thread Sedat Dilek
On Fri, Jul 12, 2019 at 11:12 AM Arnd Bergmann wrote: > > clang finds a contruct suspicious that converts an unsigned > character to a signed integer and back, causing an overflow: > > arch/x86/kvm/mmu.c:4605:39: error: implicit conversion from 'int' to 'u8' > (aka 'unsigned char') changes value

[PATCH 2/2] x86: kvm: avoid constant-conversion warning

2019-07-12 Thread Arnd Bergmann
clang finds a contruct suspicious that converts an unsigned character to a signed integer and back, causing an overflow: arch/x86/kvm/mmu.c:4605:39: error: implicit conversion from 'int' to 'u8' (aka 'unsigned char') changes value from -205 to 51 [-Werror,-Wconstant-conversion] u8