> It looks like you might need: for (i--; i >= 0; i--)
> (or: for (j = 0; j < i; j++) etc.)
>
> Because if the initial alloc_page loop goes to completion then:
> i == pagecount
> and if alloc_page loop terminates early then
> bp->b_pages[i] == NULL
> So we have gone 1 too far in both cases and
It looks like you might need: for (i--; i = 0; i--)
(or: for (j = 0; j i; j++) etc.)
Because if the initial alloc_page loop goes to completion then:
i == pagecount
and if alloc_page loop terminates early then
bp-b_pages[i] == NULL
So we have gone 1 too far in both cases and need to
Hi,
--On 9 March 2007 12:55:11 PM +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote:
Ed Cashin found a bug in the error handling code for the case where
a page allocation fails. Here's the updated version:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
Hi,
--On 9 March 2007 12:55:11 PM +0100 Christoph Hellwig [EMAIL PROTECTED] wrote:
Ed Cashin found a bug in the error handling code for the case where
a page allocation fails. Here's the updated version:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
Ed Cashin found a bug in the error handling code for the case where
a page allocation fails. Here's the updated version:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
===
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_buf.c 2007-03-08
Ed Cashin found a bug in the error handling code for the case where
a page allocation fails. Here's the updated version:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
===
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_buf.c 2007-03-08
Incore log buffers are not always a power of two of the page size.
In particular, when xfs is running over software raid devices, the
log buffers are allocated to match the size of a stripe.
However, they are always a multiple of PAGE_SIZE, so we are still safe.
Michael
Christoph Hellwig
On Wed, Mar 07, 2007 at 09:04:53AM -0800, Michael Nishimoto wrote:
> Incore log buffers are not always a power of two of the page size.
> In particular, when xfs is running over software raid devices, the
> log buffers are allocated to match the size of a stripe.
>
> However, they are always a
On Wed, Mar 07, 2007 at 05:44:24PM +0530, Shailendra Tripathi wrote:
> Hi Christoph,
>Did you do some testing for recovery when end of the physical
>log is seen ?
I ran xfsqa over it, which should catch this case.
>When you will be dealing with striped ICLOG
Hi Christoph,
Did you do some testing for recovery when end of the physical log
is seen ?
When you will be dealing with striped ICLOG buffers or big sized
ICLOGs, header size might range from 512 to 2k. Also, this header might
be split into 2 parts at the end of physical log. Then,
Currently xfs_buf_get_noaddr allocates memory using kmem_alloc which
can end up either in kmalloc or vmalloc and assigns it to the buffer.
This patch changes it to allocate individual pages and if there is
more then one maps it into kernel virtual space using vmap.
This means the minimum buffer
Currently xfs_buf_get_noaddr allocates memory using kmem_alloc which
can end up either in kmalloc or vmalloc and assigns it to the buffer.
This patch changes it to allocate individual pages and if there is
more then one maps it into kernel virtual space using vmap.
This means the minimum buffer
Hi Christoph,
Did you do some testing for recovery when end of the physical log
is seen ?
When you will be dealing with striped ICLOG buffers or big sized
ICLOGs, header size might range from 512 to 2k. Also, this header might
be split into 2 parts at the end of physical log. Then,
On Wed, Mar 07, 2007 at 05:44:24PM +0530, Shailendra Tripathi wrote:
Hi Christoph,
Did you do some testing for recovery when end of the physical
log is seen ?
I ran xfsqa over it, which should catch this case.
When you will be dealing with striped ICLOG
On Wed, Mar 07, 2007 at 09:04:53AM -0800, Michael Nishimoto wrote:
Incore log buffers are not always a power of two of the page size.
In particular, when xfs is running over software raid devices, the
log buffers are allocated to match the size of a stripe.
However, they are always a
Incore log buffers are not always a power of two of the page size.
In particular, when xfs is running over software raid devices, the
log buffers are allocated to match the size of a stripe.
However, they are always a multiple of PAGE_SIZE, so we are still safe.
Michael
Christoph Hellwig
16 matches
Mail list logo
