Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-08-07 Thread Sarah Sharp
Hi Denis, I found a couple issues with your second patch. There are non-PCI xHCI host controllers, so we can't assume the xHCI host is a PCI host. So this code can't run in the generic xHCI shutdown method: > void xhci_shutdown(struct usb_hcd *hcd) > { > + struct pci_dev *pdev; > + co

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-31 Thread Sarah Sharp
On Tue, Jul 31, 2012 at 10:06:34AM -0700, Sarah Sharp wrote: > On Tue, Jul 31, 2012 at 06:49:50AM +0200, Oliver Neukum wrote: > > On Monday 30 July 2012 15:34:06 Sarah Sharp wrote: > > > Hi Denis, > > > > > > Can you send me the output of `sudo dmidecode`? I'd like to see if I > > > can make a mo

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-31 Thread Sarah Sharp
On Tue, Jul 31, 2012 at 06:49:50AM +0200, Oliver Neukum wrote: > On Monday 30 July 2012 15:34:06 Sarah Sharp wrote: > > Hi Denis, > > > > Can you send me the output of `sudo dmidecode`? I'd like to see if I > > can make a more general patch apply to the Intense-PC. > > As this is for shutdown, w

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-31 Thread Denis Turischev
Hi Sarah, Attached dmidecode output of Intense-PC. Denis Turischev On 07/31/2012 01:34 AM, Sarah Sharp wrote: > Hi Denis, > > Can you send me the output of `sudo dmidecode`? I'd like to see if I > can make a more general patch apply to the Intense-PC. > > Sarah Sharp > # dmidecode 2.11 SMBI

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 15:34:06 Sarah Sharp wrote: > Hi Denis, > > Can you send me the output of `sudo dmidecode`? I'd like to see if I > can make a more general patch apply to the Intense-PC. As this is for shutdown, why not all systems? Regards Oliver -- To unsubscrib

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-30 Thread Sarah Sharp
Hi Denis, Can you send me the output of `sudo dmidecode`? I'd like to see if I can make a more general patch apply to the Intense-PC. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-24 Thread Sarah Sharp
On Tue, Jul 24, 2012 at 11:50:42AM +0300, Denis Turischev wrote: > On 07/23/2012 08:44 PM, Sarah Sharp wrote: > > Did you try disabling the wake on bits in the port status registers? I > > would prefer that solution if it works. > No, I didn't. Why we need to disable wake on capabilities? My theo

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-24 Thread Denis Turischev
On 07/23/2012 08:44 PM, Sarah Sharp wrote: > Did you try disabling the wake on bits in the port status registers? I > would prefer that solution if it works. No, I didn't. Why we need to disable wake on capabilities? > > Otherwise this patchset looks fine. I'll work with the hardware folks > and

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-23 Thread Sarah Sharp
Did you try disabling the wake on bits in the port status registers? I would prefer that solution if it works. Otherwise this patchset looks fine. I'll work with the hardware folks and see if this is exposed on other boards. Also, this is not a BIOS bug, but a hardware issue that can be worked

[PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-23 Thread Denis Turischev
Intense-PC is Compulab's mini-desktop with Intel Panther Point chipset. Unconditional switchover to xHCI provided by function usb_enable_xhci_ports() leads to surprising results, after shutdown system powered-on again after a few seconds. On Windows power related problems were not observed. Switch