Re: [PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail

2018-03-16 Thread Richard Weinberger
Arvind, Am Donnerstag, 15. März 2018, 18:41:58 CET schrieb arvindY: > On Thursday 15 March 2018 02:17 PM, Arvind Yadav wrote: > > On Thursday 15 March 2018 01:25 PM, Richard Weinberger wrote: > >> Am Donnerstag, 15. März 2018, 08:20:31 CET schrieb Arvind Yadav: > >>> if device_register() returned

Re: [PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail

2018-03-15 Thread arvindY
On Thursday 15 March 2018 02:17 PM, Arvind Yadav wrote: On Thursday 15 March 2018 01:25 PM, Richard Weinberger wrote: Am Donnerstag, 15. März 2018, 08:20:31 CET schrieb Arvind Yadav: if device_register() returned an error! Always use put_device() to give up the reference initialized. Like

Re: [PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail

2018-03-15 Thread Arvind Yadav
On Thursday 15 March 2018 01:25 PM, Richard Weinberger wrote: Am Donnerstag, 15. März 2018, 08:20:31 CET schrieb Arvind Yadav: if device_register() returned an error! Always use put_device() to give up the reference initialized. Like DaveM said, there is no need to shout and use "!". I will

Re: [PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail

2018-03-15 Thread Richard Weinberger
Am Donnerstag, 15. März 2018, 08:20:31 CET schrieb Arvind Yadav: > if device_register() returned an error! Always use put_device() > to give up the reference initialized. Like DaveM said, there is no need to shout and use "!". > Signed-off-by: Arvind Yadav > --- > change in v2: > Fix us

[PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail

2018-03-15 Thread Arvind Yadav
if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- change in v2: Fix use-after-free bug. move put_device() after cdev_del(). drivers/mtd/ubi/vmt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drive