Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-27 Thread Andy Shevchenko
On Tue, Feb 27, 2018 at 5:52 AM, Jisheng Zhang wrote: > On Mon, 26 Feb 2018 20:27:22 + Alexey Brodkin wrote: >> On Mon, 2018-02-26 at 20:30 +0200, Andy Shevchenko wrote: >> > On Mon, Feb 26, 2018 at 7:14 PM, Evgeniy Didin >> > wrote: >> > > On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko w

Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-26 Thread Jisheng Zhang
On Mon, 26 Feb 2018 20:27:22 + Alexey Brodkin wrote: > Hi Andy, > > On Mon, 2018-02-26 at 20:30 +0200, Andy Shevchenko wrote: > > On Mon, Feb 26, 2018 at 7:14 PM, Evgeniy Didin > > wrote: > > > On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko wrote: > > > > On Mon, Feb 26, 2018 at 5:14

Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-26 Thread Alexey Brodkin
Hi Andy, On Mon, 2018-02-26 at 20:30 +0200, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 7:14 PM, Evgeniy Didin > wrote: > > On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko wrote: > > > On Mon, Feb 26, 2018 at 5:14 PM, Evgeniy Didin > > > wrote: > > > > On Mon, 2018-02-26 at 16:39 +0200,

Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 7:14 PM, Evgeniy Didin wrote: > On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko wrote: >> On Mon, Feb 26, 2018 at 5:14 PM, Evgeniy Didin >> wrote: >> > On Mon, 2018-02-26 at 16:39 +0200, Andy Shevchenko wrote: >> > > On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin >> > >

Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-26 Thread Evgeniy Didin
On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 5:14 PM, Evgeniy Didin > wrote: > > On Mon, 2018-02-26 at 16:39 +0200, Andy Shevchenko wrote: > > > On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin > > > wrote: > > > > In commit 4c2357f57dd5 ("mmc: dw_mmc: Fix the

Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 5:14 PM, Evgeniy Didin wrote: > On Mon, 2018-02-26 at 16:39 +0200, Andy Shevchenko wrote: >> On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin >> wrote: >> > In commit 4c2357f57dd5 ("mmc: dw_mmc: Fix the CTO timeout calculation") >> > have been made changes which can cause mu

Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-26 Thread Evgeniy Didin
On Mon, 2018-02-26 at 16:39 +0200, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin > wrote: > > In commit 4c2357f57dd5 ("mmc: dw_mmc: Fix the CTO timeout calculation") > > have been made changes which can cause multiply overflow for 32-bit systems. > > The value of cto_ms i

Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-26 Thread Andy Shevchenko
On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin wrote: > In commit 4c2357f57dd5 ("mmc: dw_mmc: Fix the CTO timeout calculation") > have been made changes which can cause multiply overflow for 32-bit systems. > The value of cto_ms is lower the drto_ms, but nevertheless overflow can occur. > Lets cas

[PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems

2018-02-26 Thread Evgeniy Didin
In commit 4c2357f57dd5 ("mmc: dw_mmc: Fix the CTO timeout calculation") have been made changes which can cause multiply overflow for 32-bit systems. The value of cto_ms is lower the drto_ms, but nevertheless overflow can occur. Lets cast this multiply to u64 type which prevents overflow. Signed-of