Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-21 Thread PC Liao
Hi Matthias, On Thu, 2016-04-21 at 17:22 +0800, Matthias Brugger wrote: > > On 20/04/16 18:27, PC Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-04-20 at 21:30 +0800, Matthias Brugger wrote: > >> > >> For compatibility you should change this to something like: > >> > >> dev_warn(card->dev

Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-21 Thread Matthias Brugger
On 20/04/16 18:27, PC Liao wrote: Hi Matthias, On Wed, 2016-04-20 at 21:30 +0800, Matthias Brugger wrote: For compatibility you should change this to something like: dev_warn(card->dev, "Only one dai codec found in DTS, enabled rt5645 AD filter\n"); rt564

Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-20 Thread PC Liao
Hi Matthias, On Wed, 2016-04-20 at 21:30 +0800, Matthias Brugger wrote: > > For compatibility you should change this to something like: > > dev_warn(card->dev, "Only one dai codec found in DTS, enabled rt5645 > AD filter\n"); > rt5645_sel_asrc_clk_src(codec, RT56

Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-20 Thread Mark Brown
On Wed, Apr 20, 2016 at 05:39:50PM +0800, PC Liao wrote: > On Wed, 2016-04-20 at 16:29 +0800, Mark Brown wrote: > > On Wed, Apr 20, 2016 at 02:40:47PM +0800, PC Liao wrote: > > > +Optional properties: > > > +- capture-dai: audio codec dai on capture path > > > + <&rt5650 0> : Default setting. Con

Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-20 Thread Matthias Brugger
On 20/04/16 08:40, PC Liao wrote: This patch adds second I2S connection to rt5650 codec for capture path on mt8173-rt5650 machine driver. Signed-off-by: PC Liao --- .../devicetree/bindings/sound/mt8173-rt5650.txt|6 +++ sound/soc/mediatek/mt8173-rt5650.c | 44

Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-20 Thread PC Liao
Hi Mark, On Wed, 2016-04-20 at 16:29 +0800, Mark Brown wrote: > On Wed, Apr 20, 2016 at 02:40:47PM +0800, PC Liao wrote: > > > +Optional properties: > > +- capture-dai: audio codec dai on capture path > > + <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. > > (dai_name = rt5645-a

Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-20 Thread Mark Brown
On Wed, Apr 20, 2016 at 02:40:47PM +0800, PC Liao wrote: > +Optional properties: > +- capture-dai: audio codec dai on capture path > + <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name > = rt5645-aif1) > + <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645

[PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-19 Thread PC Liao
This patch adds second I2S connection to rt5650 codec for capture path on mt8173-rt5650 machine driver. Signed-off-by: PC Liao --- .../devicetree/bindings/sound/mt8173-rt5650.txt|6 +++ sound/soc/mediatek/mt8173-rt5650.c | 44 ++-- 2 files changed, 47 in