Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-31 Thread Rafael J. Wysocki
On Wednesday, July 31, 2013 02:52:53 PM Aaron Lu wrote: > On 07/29/2013 08:20 PM, Rafael J. Wysocki wrote: > > On Monday, July 29, 2013 10:29:36 AM Aaron Lu wrote: > >> On 07/27/2013 09:11 PM, Rafael J. Wysocki wrote: > >>> From: Rafael J. Wysocki > >>> > >>> Modify acpi_device_set_power() so that

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-30 Thread Aaron Lu
On 07/29/2013 08:20 PM, Rafael J. Wysocki wrote: > On Monday, July 29, 2013 10:29:36 AM Aaron Lu wrote: >> On 07/27/2013 09:11 PM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> Modify acpi_device_set_power() so that diagnostic messages printed by >>> it to the kernel log always cont

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-29 Thread Aaron Lu
On 07/29/2013 09:36 PM, Rafael J. Wysocki wrote: > On Monday, July 29, 2013 04:16:31 PM Sergei Shtylyov wrote: >> Hello. >> >> On 29-07-2013 16:17, Rafael J. Wysocki wrote: >> >> [...] >> >> @@ -166,20 +166,20 @@ int acpi_device_set_power(struct acpi_de [] >> if (device->paren

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-29 Thread Rafael J. Wysocki
On Monday, July 29, 2013 04:16:31 PM Sergei Shtylyov wrote: > Hello. > > On 29-07-2013 16:17, Rafael J. Wysocki wrote: > > [...] > > @@ -166,20 +166,20 @@ int acpi_device_set_power(struct acpi_de > >> [] > if (device->parent && (state < device->parent->power.state)) { > -

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-29 Thread Sergei Shtylyov
Hello. On 29-07-2013 16:17, Rafael J. Wysocki wrote: [...] @@ -166,20 +166,20 @@ int acpi_device_set_power(struct acpi_de [] if (device->parent && (state < device->parent->power.state)) { - printk(KERN_WARNING PREFIX - "Cannot set device to

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-29 Thread Rafael J. Wysocki
On Monday, July 29, 2013 10:29:36 AM Aaron Lu wrote: > On 07/27/2013 09:11 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Modify acpi_device_set_power() so that diagnostic messages printed by > > it to the kernel log always contain the name of the device concerned > > to make it

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-29 Thread Rafael J. Wysocki
On Sunday, July 28, 2013 08:11:53 PM Joe Perches wrote: > On Mon, 2013-07-29 at 11:06 +0800, Lan Tianyu wrote: > > 2013/7/27 Rafael J. Wysocki : > > > From: Rafael J. Wysocki > [] > > > drivers/acpi/device_pm.c | 22 ++ > [] > > > @@ -166,20 +166,20 @@ int acpi_device_set_pow

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-29 Thread Rafael J. Wysocki
On Monday, July 29, 2013 11:06:36 AM Lan Tianyu wrote: > 2013/7/27 Rafael J. Wysocki : > > From: Rafael J. Wysocki > > > > Modify acpi_device_set_power() so that diagnostic messages printed by > > it to the kernel log always contain the name of the device concerned > > to make it possible to ident

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-28 Thread Joe Perches
On Mon, 2013-07-29 at 11:06 +0800, Lan Tianyu wrote: > 2013/7/27 Rafael J. Wysocki : > > From: Rafael J. Wysocki [] > > drivers/acpi/device_pm.c | 22 ++ [] > > @@ -166,20 +166,20 @@ int acpi_device_set_power(struct acpi_de [] > > if (device->parent && (state < device

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-28 Thread Lan Tianyu
2013/7/27 Rafael J. Wysocki : > From: Rafael J. Wysocki > > Modify acpi_device_set_power() so that diagnostic messages printed by > it to the kernel log always contain the name of the device concerned > to make it possible to identify the device that triggered the message > if need be. > > Also re

Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-28 Thread Aaron Lu
On 07/27/2013 09:11 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Modify acpi_device_set_power() so that diagnostic messages printed by > it to the kernel log always contain the name of the device concerned > to make it possible to identify the device that triggered the message > if

[PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names

2013-07-27 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Modify acpi_device_set_power() so that diagnostic messages printed by it to the kernel log always contain the name of the device concerned to make it possible to identify the device that triggered the message if need be. Also replace printk(KERN_WARNING ) with dev_warn()