Re: [PATCH 2/3] ARM: cache-uniphier: refactor jump label to follow coding style guideline

2016-11-04 Thread Masahiro Yamada
2016-11-04 22:32 GMT+09:00 Russell King - ARM Linux : > On Fri, Nov 04, 2016 at 09:50:56PM +0900, Masahiro Yamada wrote: >> Hi Russell, >> >> 2016-11-04 21:23 GMT+09:00 Russell King - ARM Linux : >> > On Fri, Nov 04, 2016 at 08:43:35PM +0900, Masahiro Yamada wrote: >> >> Documentation/CodingStyle r

Re: [PATCH 2/3] ARM: cache-uniphier: refactor jump label to follow coding style guideline

2016-11-04 Thread Russell King - ARM Linux
On Fri, Nov 04, 2016 at 09:50:56PM +0900, Masahiro Yamada wrote: > Hi Russell, > > 2016-11-04 21:23 GMT+09:00 Russell King - ARM Linux : > > On Fri, Nov 04, 2016 at 08:43:35PM +0900, Masahiro Yamada wrote: > >> Documentation/CodingStyle recommends to use label names which say > >> what the goto do

Re: [PATCH 2/3] ARM: cache-uniphier: refactor jump label to follow coding style guideline

2016-11-04 Thread Masahiro Yamada
Hi Russell, 2016-11-04 21:23 GMT+09:00 Russell King - ARM Linux : > On Fri, Nov 04, 2016 at 08:43:35PM +0900, Masahiro Yamada wrote: >> Documentation/CodingStyle recommends to use label names which say >> what the goto does or why the goto exists. >> >> Just in case, split it up into three labels

Re: [PATCH 2/3] ARM: cache-uniphier: refactor jump label to follow coding style guideline

2016-11-04 Thread Russell King - ARM Linux
On Fri, Nov 04, 2016 at 08:43:35PM +0900, Masahiro Yamada wrote: > Documentation/CodingStyle recommends to use label names which say > what the goto does or why the goto exists. > > Just in case, split it up into three labels because the CodingStyle > says "one err bugs" is a common type of bug (a

[PATCH 2/3] ARM: cache-uniphier: refactor jump label to follow coding style guideline

2016-11-04 Thread Masahiro Yamada
Documentation/CodingStyle recommends to use label names which say what the goto does or why the goto exists. Just in case, split it up into three labels because the CodingStyle says "one err bugs" is a common type of bug (although, I do not believe the current code includes such a bug). During th