Re: [PATCH 2/3] ARM: vfp: fix VFPv3 hwcap detection on non-ARM vfp implementations

2014-10-08 Thread Will Deacon
Hi all, On Wed, Oct 01, 2014 at 06:54:18PM +0100, Stephen Boyd wrote: > On 09/19/14 11:24, Stephen Boyd wrote: > > On 09/18/14 15:46, Russell King - ARM Linux wrote: > >> I know that you're changing this to conform with the ARM ARM, but we > >> have to consider that before VFP was subsumed into th

Re: [PATCH 2/3] ARM: vfp: fix VFPv3 hwcap detection on non-ARM vfp implementations

2014-10-01 Thread Stephen Boyd
On 10/01/14 14:50, Russell King - ARM Linux wrote: > On Fri, Sep 19, 2014 at 11:24:01AM -0700, Stephen Boyd wrote: >> >> Do you, or anyone else, know of other implementations? I *hope* that >> this same exercise was done by the VFP architects before they >> re-purposed bits but who knows. If nobody

Re: [PATCH 2/3] ARM: vfp: fix VFPv3 hwcap detection on non-ARM vfp implementations

2014-10-01 Thread Russell King - ARM Linux
On Fri, Sep 19, 2014 at 11:24:01AM -0700, Stephen Boyd wrote: > Thank you for the warm welcome! I looked at the TRMs for ARM11 and ARM9. > I can't find anywhere where VFPv2 is supported and these bits are set. > > Bits 22-16 of FPSID: > > ARM1136r1p5: 0x01 > ARM1136r1p3: 0x01 > ARM1176:

Re: [PATCH 2/3] ARM: vfp: fix VFPv3 hwcap detection on non-ARM vfp implementations

2014-10-01 Thread Stephen Boyd
On 09/19/14 11:24, Stephen Boyd wrote: > On 09/18/14 15:46, Russell King - ARM Linux wrote: >> On Thu, Sep 18, 2014 at 02:43:11PM -0700, Stephen Boyd wrote: >>> diff --git a/arch/arm/include/asm/vfp.h b/arch/arm/include/asm/vfp.h >>> index f4ab34fd4f72..76d3f6907cce 100644 >>> --- a/arch/arm/includ

Re: [PATCH 2/3] ARM: vfp: fix VFPv3 hwcap detection on non-ARM vfp implementations

2014-09-19 Thread Stephen Boyd
On 09/18/14 15:46, Russell King - ARM Linux wrote: > On Thu, Sep 18, 2014 at 02:43:11PM -0700, Stephen Boyd wrote: >> diff --git a/arch/arm/include/asm/vfp.h b/arch/arm/include/asm/vfp.h >> index f4ab34fd4f72..76d3f6907cce 100644 >> --- a/arch/arm/include/asm/vfp.h >> +++ b/arch/arm/include/asm/vfp

Re: [PATCH 2/3] ARM: vfp: fix VFPv3 hwcap detection on non-ARM vfp implementations

2014-09-18 Thread Russell King - ARM Linux
On Thu, Sep 18, 2014 at 02:43:11PM -0700, Stephen Boyd wrote: > diff --git a/arch/arm/include/asm/vfp.h b/arch/arm/include/asm/vfp.h > index f4ab34fd4f72..76d3f6907cce 100644 > --- a/arch/arm/include/asm/vfp.h > +++ b/arch/arm/include/asm/vfp.h > @@ -21,7 +21,7 @@ > #define FPSID_FORMAT_MASK(0

[PATCH 2/3] ARM: vfp: fix VFPv3 hwcap detection on non-ARM vfp implementations

2014-09-18 Thread Stephen Boyd
The subarchitecture field in the fpsid register is 7 bits wide. The topmost bit is used to designate that the subarchitecture designer is not ARM. We use this field to determine which VFP version is supported by the CPU. Since the topmost bit is ignored with the current mask we detect non-ARM subar