Kristian Høgsberg wrote:
> Yup, I've done away with the bitfields and switched to a mix of __le16
> and __le32 struct fields.
I suppose the struct should get __attribute__((packed)) then.
But is the order of two adjacent __le16 fields (i.e. two halves of a
quadlet) independent of host byte order?
Jeff Garzik wrote:
Thanks for reviewing this. I'm updating my git repo with your changes now,
will send an updated patch set in a few days.
+struct descriptor {
+u32 req_count:16;
+
+u32 wait:2;
+u32 branch:2;
+u32 irq:2;
+u32 yy:1;
+u32 ping:1;
+
+u32 key:3;
+
> > +struct descriptor {
> > + u32 req_count:16;
> > +
> > + u32 wait:2;
> > + u32 branch:2;
> > + u32 irq:2;
> > + u32 yy:1;
> > + u32 ping:1;
> > +
> > + u32 key:3;
> > + u32 status:1;
> > + u32 command:4;
> > +
> > + u32 data_address;
> > + u32 branch_address;
> > +
> > +
Kristian Høgsberg wrote:
Add the OHCI driver to the stack and build system.
Signed-off-by: Kristian Høgsberg <[EMAIL PROTECTED]>
---
drivers/fw/fw-ohci.c | 1334 ++
drivers/fw/fw-ohci.h | 152 ++
2 files changed, 1486 insertions(+), 0 deleti
On Tue, 05 Dec 2006 00:22:45 -0500, "Kristian Høgsberg" <[EMAIL PROTECTED]>
wrote:
Your wonderful crossed-o might be ok here (or it would've been if only
your mailer worked -- notice that the name is right in the "On" tag
line above):
> Signed-off-by: Kristian Høgsberg <[EMAIL PROTECTED]>
> ---
Add the OHCI driver to the stack and build system.
Signed-off-by: Kristian Høgsberg <[EMAIL PROTECTED]>
---
drivers/fw/fw-ohci.c | 1334 ++
drivers/fw/fw-ohci.h | 152 ++
2 files changed, 1486 insertions(+), 0 deletions(-)
diff --git a/driver
6 matches
Mail list logo
