Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-28 Thread Marcelo Tosatti
On Wed, Nov 28, 2012 at 10:55:26PM +0800, Xiao Guangrong wrote: > On 11/28/2012 10:01 PM, Gleb Natapov wrote: > > On Wed, Nov 28, 2012 at 11:15:13AM +0800, Xiao Guangrong wrote: > >> On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: > >>> On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-28 Thread Xiao Guangrong
On 11/28/2012 10:01 PM, Gleb Natapov wrote: > On Wed, Nov 28, 2012 at 11:15:13AM +0800, Xiao Guangrong wrote: >> On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: >>> On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: >> +static bool reexecute_instruction(struct kvm_vcpu *vcpu,

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-28 Thread Gleb Natapov
On Wed, Nov 28, 2012 at 11:15:13AM +0800, Xiao Guangrong wrote: > On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: > > On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: > +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long > cr2) > { > -

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-28 Thread Gleb Natapov
On Wed, Nov 28, 2012 at 11:15:13AM +0800, Xiao Guangrong wrote: On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long cr2) { -gpa_t gpa; +

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-28 Thread Xiao Guangrong
On 11/28/2012 10:01 PM, Gleb Natapov wrote: On Wed, Nov 28, 2012 at 11:15:13AM +0800, Xiao Guangrong wrote: On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-28 Thread Marcelo Tosatti
On Wed, Nov 28, 2012 at 10:55:26PM +0800, Xiao Guangrong wrote: On 11/28/2012 10:01 PM, Gleb Natapov wrote: On Wed, Nov 28, 2012 at 11:15:13AM +0800, Xiao Guangrong wrote: On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote:

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-27 Thread Xiao Guangrong
On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: > On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long cr2) { - gpa_t gpa; + gpa_t gpa = cr2; pfn_t pfn; - if

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-27 Thread Marcelo Tosatti
On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: > >> +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long > >> cr2) > >> { > >> - gpa_t gpa; > >> + gpa_t gpa = cr2; > >>pfn_t pfn; > >> > >> - if (tdp_enabled) > >> + if

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-27 Thread Marcelo Tosatti
On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long cr2) { - gpa_t gpa; + gpa_t gpa = cr2; pfn_t pfn; - if (tdp_enabled) + if (!ACCESS_ONCE(vcpu-kvm-arch.indirect_shadow_pages))

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-27 Thread Xiao Guangrong
On 11/28/2012 07:32 AM, Marcelo Tosatti wrote: On Tue, Nov 27, 2012 at 11:13:11AM +0800, Xiao Guangrong wrote: +static bool reexecute_instruction(struct kvm_vcpu *vcpu, unsigned long cr2) { - gpa_t gpa; + gpa_t gpa = cr2; pfn_t pfn; - if (tdp_enabled) + if

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-26 Thread Xiao Guangrong
On 11/27/2012 06:37 AM, Marcelo Tosatti wrote: > On Tue, Nov 20, 2012 at 07:59:10AM +0800, Xiao Guangrong wrote: >> Currently, reexecute_instruction refused to retry all instructions. If >> nested npt is used, the emulation may be caused by shadow page, it can >> be fixed by dropping the shadow

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-26 Thread Marcelo Tosatti
On Tue, Nov 20, 2012 at 07:59:10AM +0800, Xiao Guangrong wrote: > Currently, reexecute_instruction refused to retry all instructions. If > nested npt is used, the emulation may be caused by shadow page, it can > be fixed by dropping the shadow page > > Signed-off-by: Xiao Guangrong > --- >

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-26 Thread Marcelo Tosatti
On Tue, Nov 20, 2012 at 07:59:10AM +0800, Xiao Guangrong wrote: Currently, reexecute_instruction refused to retry all instructions. If nested npt is used, the emulation may be caused by shadow page, it can be fixed by dropping the shadow page Signed-off-by: Xiao Guangrong

Re: [PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-26 Thread Xiao Guangrong
On 11/27/2012 06:37 AM, Marcelo Tosatti wrote: On Tue, Nov 20, 2012 at 07:59:10AM +0800, Xiao Guangrong wrote: Currently, reexecute_instruction refused to retry all instructions. If nested npt is used, the emulation may be caused by shadow page, it can be fixed by dropping the shadow page

[PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-19 Thread Xiao Guangrong
Currently, reexecute_instruction refused to retry all instructions. If nested npt is used, the emulation may be caused by shadow page, it can be fixed by dropping the shadow page Signed-off-by: Xiao Guangrong --- arch/x86/kvm/x86.c | 14 -- 1 files changed, 8 insertions(+), 6

[PATCH 2/3] KVM: x86: let reexecute_instruction work for tdp

2012-11-19 Thread Xiao Guangrong
Currently, reexecute_instruction refused to retry all instructions. If nested npt is used, the emulation may be caused by shadow page, it can be fixed by dropping the shadow page Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/x86.c | 14 -- 1 files