Re: [alsa-devel] [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-27 Thread Rene Herman
On 27-11-07 17:34, Thomas Renninger wrote: On Wed, 2007-11-21 at 10:53 +0100, Takashi Iwai wrote: At Tue, 20 Nov 2007 15:31:26 +0100, Rene Herman wrote: On 20-11-07 15:19, Thomas Renninger wrote: At the end is some example code how things could get even more cleaned up. It shows how I think

Re: [alsa-devel] [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-27 Thread Thomas Renninger
On Wed, 2007-11-21 at 10:53 +0100, Takashi Iwai wrote: > At Tue, 20 Nov 2007 15:31:26 +0100, > Rene Herman wrote: > > > > On 20-11-07 15:19, Thomas Renninger wrote: > > > > > At the end is some example code how things could get even more cleaned > > > up. It shows how I think pnp layer and one

Re: [alsa-devel] [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-27 Thread Thomas Renninger
On Wed, 2007-11-21 at 10:53 +0100, Takashi Iwai wrote: At Tue, 20 Nov 2007 15:31:26 +0100, Rene Herman wrote: On 20-11-07 15:19, Thomas Renninger wrote: At the end is some example code how things could get even more cleaned up. It shows how I think pnp layer and one example driver

Re: [alsa-devel] [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-27 Thread Rene Herman
On 27-11-07 17:34, Thomas Renninger wrote: On Wed, 2007-11-21 at 10:53 +0100, Takashi Iwai wrote: At Tue, 20 Nov 2007 15:31:26 +0100, Rene Herman wrote: On 20-11-07 15:19, Thomas Renninger wrote: At the end is some example code how things could get even more cleaned up. It shows how I think

Re: [alsa-devel] [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-21 Thread Takashi Iwai
At Tue, 20 Nov 2007 15:31:26 +0100, Rene Herman wrote: > > On 20-11-07 15:19, Thomas Renninger wrote: > > > At the end is some example code how things could get even more cleaned > > up. It shows how I think pnp layer and one example driver would get > > adjusted. There are not that much drivers

Re: [alsa-devel] [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-21 Thread Takashi Iwai
At Tue, 20 Nov 2007 15:31:26 +0100, Rene Herman wrote: On 20-11-07 15:19, Thomas Renninger wrote: At the end is some example code how things could get even more cleaned up. It shows how I think pnp layer and one example driver would get adjusted. There are not that much drivers making

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Andi Kleen
Alan Cox <[EMAIL PROTECTED]> writes: > > Is it actually even worth changing in the first place ? You seem to be > complicating the code not simplyifying it, and at the end of the day > ISAPnP is obsolete and BIOS PnP is obsoleted by ACPI The PNP interface is used by the ACPI code to tell the

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Thomas Renninger
On Tue, 2007-11-20 at 15:31 +0100, Rene Herman wrote: > On 20-11-07 15:19, Thomas Renninger wrote: > > > At the end is some example code how things could get even more cleaned > > up. It shows how I think pnp layer and one example driver would get > > adjusted. There are not that much drivers

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Alan Cox
> At the end is some example code how things could get even more cleaned > up. It shows how I think pnp layer and one example driver would get Your example adds rather than removes code. > If this is not an option, please advise how to move on here: > Still use struct resources for dma and irq,

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Rene Herman
On 20-11-07 15:19, Thomas Renninger wrote: At the end is some example code how things could get even more cleaned up. It shows how I think pnp layer and one example driver would get adjusted. There are not that much drivers making use of pnp_resource_change... The ALSA ISA-PnP drivers do in

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Thomas Renninger
On Tue, 2007-11-20 at 12:31 +, Alan Cox wrote: > On Tue, 20 Nov 2007 10:51:23 +0100 > Thomas Renninger <[EMAIL PROTECTED]> wrote: > > > Unify the pnp macros to access resources in the pnp resource table > > NAK > > > port, mem, dma and irq resource macros are now all used in the same > >

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Alan Cox
On Tue, 20 Nov 2007 10:51:23 +0100 Thomas Renninger <[EMAIL PROTECTED]> wrote: > Unify the pnp macros to access resources in the pnp resource table NAK > port, mem, dma and irq resource macros are now all used in the same > way. This is the basis (or makes it at least easier) for changing how >

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Rene Herman
On 20-11-07 10:51, Thomas Renninger wrote: Unify the pnp macros to access resources in the pnp resource table port, mem, dma and irq resource macros are now all used in the same way. This is the basis (or makes it at least easier) for changing how the resources are allocated for memory

[PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Thomas Renninger
Unify the pnp macros to access resources in the pnp resource table port, mem, dma and irq resource macros are now all used in the same way. This is the basis (or makes it at least easier) for changing how the resources are allocated for memory optimizations. Signed-off-by: Thomas Renninger

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Rene Herman
On 20-11-07 10:51, Thomas Renninger wrote: Unify the pnp macros to access resources in the pnp resource table port, mem, dma and irq resource macros are now all used in the same way. This is the basis (or makes it at least easier) for changing how the resources are allocated for memory

[PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Thomas Renninger
Unify the pnp macros to access resources in the pnp resource table port, mem, dma and irq resource macros are now all used in the same way. This is the basis (or makes it at least easier) for changing how the resources are allocated for memory optimizations. Signed-off-by: Thomas Renninger

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Alan Cox
On Tue, 20 Nov 2007 10:51:23 +0100 Thomas Renninger [EMAIL PROTECTED] wrote: Unify the pnp macros to access resources in the pnp resource table NAK port, mem, dma and irq resource macros are now all used in the same way. This is the basis (or makes it at least easier) for changing how the

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Thomas Renninger
On Tue, 2007-11-20 at 12:31 +, Alan Cox wrote: On Tue, 20 Nov 2007 10:51:23 +0100 Thomas Renninger [EMAIL PROTECTED] wrote: Unify the pnp macros to access resources in the pnp resource table NAK port, mem, dma and irq resource macros are now all used in the same way. This is the

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Rene Herman
On 20-11-07 15:19, Thomas Renninger wrote: At the end is some example code how things could get even more cleaned up. It shows how I think pnp layer and one example driver would get adjusted. There are not that much drivers making use of pnp_resource_change... The ALSA ISA-PnP drivers do in

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Alan Cox
At the end is some example code how things could get even more cleaned up. It shows how I think pnp layer and one example driver would get Your example adds rather than removes code. If this is not an option, please advise how to move on here: Still use struct resources for dma and irq, but

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Thomas Renninger
On Tue, 2007-11-20 at 15:31 +0100, Rene Herman wrote: On 20-11-07 15:19, Thomas Renninger wrote: At the end is some example code how things could get even more cleaned up. It shows how I think pnp layer and one example driver would get adjusted. There are not that much drivers making use

Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table

2007-11-20 Thread Andi Kleen
Alan Cox [EMAIL PROTECTED] writes: Is it actually even worth changing in the first place ? You seem to be complicating the code not simplyifying it, and at the end of the day ISAPnP is obsolete and BIOS PnP is obsoleted by ACPI The PNP interface is used by the ACPI code to tell the various