Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

2016-06-02 Thread Alex Thorlton
On Thu, Jun 02, 2016 at 04:14:03PM -0500, Alex Thorlton wrote: > On Thu, Jun 02, 2016 at 08:45:47PM +0100, Matt Fleming wrote: > > Unless I've missed it, I didn't see an explanation in the changelog of > > why it's OK to switch from using __va(tab->function) to tab->function > > directly, which

Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

2016-06-02 Thread Alex Thorlton
On Thu, Jun 02, 2016 at 04:14:03PM -0500, Alex Thorlton wrote: > On Thu, Jun 02, 2016 at 08:45:47PM +0100, Matt Fleming wrote: > > Unless I've missed it, I didn't see an explanation in the changelog of > > why it's OK to switch from using __va(tab->function) to tab->function > > directly, which

Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

2016-06-02 Thread Alex Thorlton
On Thu, Jun 02, 2016 at 08:45:47PM +0100, Matt Fleming wrote: > Unless I've missed it, I didn't see an explanation in the changelog of > why it's OK to switch from using __va(tab->function) to tab->function > directly, which presumably is a physical address. > > Was that intended? It was

Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

2016-06-02 Thread Alex Thorlton
On Thu, Jun 02, 2016 at 08:45:47PM +0100, Matt Fleming wrote: > Unless I've missed it, I didn't see an explanation in the changelog of > why it's OK to switch from using __va(tab->function) to tab->function > directly, which presumably is a physical address. > > Was that intended? It was

Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

2016-06-02 Thread Matt Fleming
On Wed, 18 May, at 02:11:40PM, Alex Thorlton wrote: > Now that the efi_call_virt macro has been generalized to be able to > use EFI system tables besides efi.systab, we are able to convert our > uv_bios_call wrapper to use this standard EFI callback mechanism. > > This simple change is part of a

Re: [PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

2016-06-02 Thread Matt Fleming
On Wed, 18 May, at 02:11:40PM, Alex Thorlton wrote: > Now that the efi_call_virt macro has been generalized to be able to > use EFI system tables besides efi.systab, we are able to convert our > uv_bios_call wrapper to use this standard EFI callback mechanism. > > This simple change is part of a

[PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

2016-05-18 Thread Alex Thorlton
Now that the efi_call_virt macro has been generalized to be able to use EFI system tables besides efi.systab, we are able to convert our uv_bios_call wrapper to use this standard EFI callback mechanism. This simple change is part of a much larger effort to recover from some issues with the way we

[PATCH 2/3] Update uv_bios_call to use efi_call_virt_generic

2016-05-18 Thread Alex Thorlton
Now that the efi_call_virt macro has been generalized to be able to use EFI system tables besides efi.systab, we are able to convert our uv_bios_call wrapper to use this standard EFI callback mechanism. This simple change is part of a much larger effort to recover from some issues with the way we