Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

2013-09-28 Thread Tomasz Figa
On Friday 27 of September 2013 18:37:56 Yadwinder Singh Brar wrote: > Hi Tomasz, > > On Thu, Sep 26, 2013 at 7:30 PM, Tomasz Figa wrote: > > Hi Yadwinder, > > > > I haven't reviewed this series yet, but let me clarify some things > > from > > your comments. > > > > On Thursday 26 of September 2

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

2013-09-27 Thread Yadwinder Singh Brar
Hi Tomasz, On Thu, Sep 26, 2013 at 7:30 PM, Tomasz Figa wrote: > Hi Yadwinder, > > I haven't reviewed this series yet, but let me clarify some things from > your comments. > > On Thursday 26 of September 2013 17:38:58 Yadwinder Singh Brar wrote: >> > + >> > +/* Helper macros to define clock array

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

2013-09-26 Thread Tomasz Figa
Hi Yadwinder, I haven't reviewed this series yet, but let me clarify some things from your comments. On Thursday 26 of September 2013 17:38:58 Yadwinder Singh Brar wrote: > > + > > +/* Helper macros to define clock arrays. */ > > +#define FIXED_RATE_CLOCKS(name)\ > > + stati

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

2013-09-26 Thread Yadwinder Singh Brar
Hi Mateusz, After a quick view, just few things regarding coding styles. [...] > +#defineGENERAL_STATUS 0x0104 > +#defineCAM_MUX_SEL 0x0300 > +#defineMIXER_OUT_SEL 0x0304 > +#defineLPMP3_MODE_SEL 0x0308 > +#define MIPI_PHY_C

[PATCH 2/3] clk: samsung: Add clock driver for s5pc100

2013-09-24 Thread Mateusz Krawczuk
This patch adds new, Common Clock Framework-based clock driver for Samsung S5PC100 SoCs. The driver is just added. Signed-off-by: Mateusz Krawczuk Signed-off-by: Kyungmin Park --- .../bindings/clock/samsung,s5pc100-clock.txt | 72 +++ drivers/clk/samsung/Makefile |